style, fix: Several redesigns and bug fixes.#1157
style, fix: Several redesigns and bug fixes.#1157ilyassesalama merged 16 commits intoSketchware-Pro:material-redesignfrom
Conversation
…e Android Manifest Manager event have been changed to aB dialog
thisisshadow
changed the title
thisisshadow
changed the title
|
Great improvements, I've tested your changes and everything seems good so far. However, more in depth review of your pull request is still needed since you have done a lot of changes here and there. Kindly, don't close this pull request until we review it. |
| import mod.SketchwareUtil; | ||
| import mod.hey.studios.util.Helper; | ||
|
|
||
| public class kv extends LinearLayout implements nv { |
There was a problem hiding this comment.
Hey, it seems that you have decompiled this class. It'd be better if you first commit the decompiled file (without any changes) and refactor/fix it in another separate commit. That makes it easier to debug issues that might have been caused by decompiling later on.
Thanks
ilyassesalama
added
the
UI/UX
|
It has been waiting for approval for about 2 weeks 😑 |
|
The changes are massive (97 changed files) and the current modders don't have much free time rn, so that's probably why |
Okay bro |
|
I just got the time to review your pull request. Your changes are outstanding, thank you @thisisshadow for your contribution. We hope to see more contributions from you, the community will appreciate them. I have one note about your commits, can you separate them next time instead of committing many files under one title even if the changes are not related to what you've named your commit. Separating them would help with reviewing your pull requests. |
Thank you bro, next time I will do as you say. |
ilyassesalama
added
the
merged
3 participants
No description provided.