Skip to content

fix,feat: Improve DebugActivity#1148

Merged
hasrat-ali merged 4 commits intoSketchware-Pro:mainfrom
khaled-0:fix-DebugActivity
Jul 15, 2024
Merged

fix,feat: Improve DebugActivity#1148
hasrat-ali merged 4 commits intoSketchware-Pro:mainfrom
khaled-0:fix-DebugActivity

Conversation

@khaled-0
Copy link
Contributor

@khaled-0 khaled-0 commented Jun 1, 2024

fixes #1140
DebugActivity now launched every time using intent because,
AlarmManager is unreliable

Also changed the crash message view from dialog to a bi directional scroll
Profit: formatted crash logs

Screenshot from 2024-06-01 13-32-45

@j-px
Copy link
Contributor

j-px commented Jun 1, 2024

Works great. What's suboptimal is that you can't easily take a screenshot of the entire stack trace anymore. I'm 100 % sure most users would not care and then start sending cut-off ones, making every helper's life harder. I think the horizontal scroll feature should be removed.

@khaled-0
Copy link
Contributor Author

khaled-0 commented Jun 1, 2024

Works great. What's suboptimal is that you can't easily take a screenshot of the entire stack trace anymore. I'm 100 % sure most users would not care and then start sending cut-off ones, making every helper's life harder. I think the horizontal scroll feature should be removed.

Or how about a copy button? because removing hscroll breaks the stack messages

@j-px
Copy link
Contributor

j-px commented Jun 1, 2024

They'll probably still ignore that.

@khaled-0
Copy link
Contributor Author

khaled-0 commented Jun 1, 2024

I dunno, go ahead and remove it then i guess
Or add a subtitle message to send the message copied

@RoyTheReal
Copy link

I think just adding a copy button above or below the error code with be good enough

@hasrat-ali
Copy link
Contributor

Can't we just add inbuilt screenshot button?

@hasrat-ali hasrat-ali requested review from j-px and removed request for j-px June 12, 2024 11:10
@j-px
Copy link
Contributor

j-px commented Jun 14, 2024

I think just adding a copy button above or below the error code with be good enough

There's a copy button in Sketchware Pro's crash screen. Not a lot of people used it afair. At least the messages weren't cut off in the dialog.

@PranavPurwar
Copy link
Collaborator

I think just adding a copy button above or below the error code with be good enough

There's a copy button in Sketchware Pro's crash screen. Not a lot of people used it afair. At least the messages weren't cut off in the dialog.

There isn't, yet.

@j-px
Copy link
Contributor

j-px commented Jun 14, 2024

wait maybe I misremembered lmao

@PranavPurwar
Copy link
Collaborator

yeah, it was never there so I made #1143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When App Crashes, Debug Screen no longer shows with error

5 participants