Skip to content

Conversation

@Sjors
Copy link
Owner

@Sjors Sjors commented Jan 9, 2024

Implements stratum-mining/sv2-spec#66.

Matching SRI pull request: stratum-mining/stratum#737

This changes the handshake in two ways:

  1. Public keys are encoded as EllSwift: 64 instead of 32 bytes
  2. ECDH is done via ellswift_ecdh_xonly

Both are defined in BIP324

It does not change (x-only) public encoding in the certificate.

The main implementation is in commit "Use EllSwift for handshake pubkeys and ECDH". The two revert commits allow dropping their corresponding commits in bitcoin#28983

@Sjors Sjors marked this pull request as ready for review January 9, 2024 14:05
@Sjors Sjors changed the title 2024/01/sv2 ellswift Stratum v2 handshake using EllSwift Jan 9, 2024
@Sjors Sjors force-pushed the 2024/01/sv2-ellswift branch 3 times, most recently from a1f476f to a32c20d Compare January 9, 2024 16:50
@Sjors Sjors force-pushed the 2023/11/sv2-poll branch 3 times, most recently from 7a2b96c to 85c3e9e Compare January 12, 2024 15:57
@Sjors Sjors force-pushed the 2023/11/sv2-poll branch 2 times, most recently from aa952cb to d5d9695 Compare January 15, 2024 11:55
@Sjors Sjors force-pushed the 2024/01/sv2-ellswift branch from a32c20d to 26bf4db Compare January 15, 2024 12:45
@Sjors Sjors force-pushed the 2024/01/sv2-ellswift branch from 26bf4db to e2ec1e6 Compare January 15, 2024 17:05
@Sjors Sjors force-pushed the 2024/01/sv2-ellswift branch from e2ec1e6 to aa37769 Compare January 15, 2024 17:38
@Sjors Sjors force-pushed the 2024/01/sv2-ellswift branch from aa37769 to 639de78 Compare January 15, 2024 18:47
@Sjors Sjors force-pushed the 2024/01/sv2-ellswift branch from 639de78 to a10a334 Compare January 15, 2024 19:44
Sjors added 2 commits January 16, 2024 14:08
This reverts commit 6eb5e14c773a0c8140d2ae07bb371688a8d9669d.
This reverts commit eb51cd2497a72be7cc2572cc56c1ba68fc7873bd.
@Sjors Sjors force-pushed the 2024/01/sv2-ellswift branch 2 times, most recently from 4226418 to 345e112 Compare January 16, 2024 16:56
@Sjors Sjors force-pushed the 2024/01/sv2-ellswift branch 26 times, most recently from 3b5c5d4 to f167acf Compare January 18, 2024 11:02
@Sjors
Copy link
Owner Author

Sjors commented Feb 5, 2024

@Sjors Sjors closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants