Lock free Read/Write Identical Request Implementation#124
Merged
JimBobSquarePants merged 2 commits intoSixLabors:js/faster-cachefrom Sep 17, 2020
Merged
Conversation
|
@deanmarcussen @JimBobSquarePants can you guys please provide more details about this change? How is it better (pros/cons) vs the previous implementation with the AsyncLock? |
Member
|
It’s about 30x faster as I recall from the load test benchmarks |
Contributor
|
To be precise, under stress it went from 2K RPS to 60K RPS, which was the static file middleware raw perf. |
Collaborator
Author
|
Worth having a read of the full pr from @JimBobSquarePants #121 where the bottlenecks in the existing lock where identified and we tested the lock free approach |
|
Thanks a lot guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Proposes replacing the
AsyncKeyLockwith an implementation based aroundConcurrentDictionary.Note: I have not removed the
AsyncKeyLockcode or related test code.Test coverage from the Integration Tests.