V4 - Use BPP from Color Writer for Compressor #2916
Merged
JimBobSquarePants merged 1 commit intomainfrom Apr 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the compressor uses the calculated BitsPerPixel from the Color Writer, aligning the encoder behavior with the computed image properties.
- Added a constant for Issue2909 in the test images.
- Introduced two new tests verifying LZW and Deflate compressions using the Issue2909 test image.
- Refactored the TiffEncoderCore compressor creation to use colorWriter.BitsPerPixel instead of an external bitsPerPixel value.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/ImageSharp.Tests/TestImages.cs | Added a new constant for Issue2909 test image reference. |
| tests/ImageSharp.Tests/Formats/Tiff/TiffEncoderTests.cs | Added new tests for LZW and Deflate compression support. |
| src/ImageSharp/Formats/Tiff/TiffEncoderCore.cs | Refactored compressor instantiation to use the color writer’s BitsPerPixel. |
Files not reviewed (1)
- tests/Images/Input/Tiff/Issues/Issue2909.tiff: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Uses the computed
BitsPerPixelfrom the color writer instance for the compressor to ensure parity.Fixes #2909