Repository navigation
Commit 8fd6656
build(npm): committish-free allowScripts key (npm-12-proof); correct EALLOWSCRIPTS root-cause record (#2349)
* docs(deploy): webhook-secret repair — verified end-to-end; STATUS de-spliced; stale Coolify uuid fixed
Rebuilt from monet/deploy-webhook-repair onto current main (the lane worktree acquired a
concurrent session mid-land, so this lands from a throwaway worktree per the lane-busy
protocol; the original branch is superseded by this one).
Content, now with the outcome recorded:
- docs/rollouts/2026-08-02-deploy-webhook-secret-repair.md: full receipts of the repair
(every main push answered 'Invalid signature' by Coolify -> zero deployments created;
hook secret synced from the app's manual_webhook_secret_github; duplicate hook deleted;
redelivery created a real deployment) and the verification:
scripts/verify-deploy-sha.sh 19dfd51 = PASS ~04:47Z. Prod runs main HEAD; the
30-finding remediation (#2341) is live, and unauthenticated /api/health confirmed
minimized in prod (USD balances + raw storage bytes gone; schedulerLease.owner residual
filed as follow-up).
- AGENTS.md: Coolify stanza corrected — app uuid is `socratic-app` (dockerfile build,
SSH deploy-key source, manual webhook endpoint with HMAC validation); the old
m1os7ijf31bg3fanil152e4b/nixpacks/GitHub-App description was stale and the failure mode
(green 200s on the hook page while the delivery response body says Invalid signature)
is now documented where the next diagnostician will look.
- STATUS.md: de-spliced again (union-merge had re-duplicated table rows and resurrected
the stale owner-action deploy blocker); deploy blocker -> RESOLVED with receipts; npm
EALLOWSCRIPTS blocker -> RESOLVED by #2345 with the stale-allowScripts-tag recurrence
warning; next actions updated.
- docs/EFFORT-LOG.md: repair row moved to COMPLETED+VERIFIED.
Docs only — no code.
Co-Authored-By: Claude <[email protected]>
* build(npm): committish-free allowScripts key (npm-12-proof); correct the EALLOWSCRIPTS root-cause record
The reproduction agent's 10-case isolated investigation refuted the explanation this seat
recorded earlier: a stale allowScripts tag was NOT the trigger (a project with no
allowScripts field at all installs the git dep fine, and a clean-shell npm ci with the
repo's exact pre-#2345 files passes). The real triggers are an `allow-scripts` line in any
.npmrc layer or an inherited npm_config_allow_scripts env var, which npm forwards into its
own git-dep preparation subprocess and then rejects as a flag — upstream npm/cli#9783,
open, unfixed through npm 12.0.2. This Mac had live npx-launched processes exporting
[email protected]/wasp-cli; any descendant shell fails every install
instantly. npm@10 "worked" because it ignores the unknown config.
The one-line code change is forward-looking: npm's allowScripts matcher compares a git
key's committish against the lockfile's resolved 40-char SHA, so a tag-form key
(#v2.4.1) can never match — dead weight today (warning), but npm 12 escalates uncovered
scripts to a HARD BLOCK, which would silently block congress-trading-shared's `prepare`
(tsup build) and ship the package without dist/. The committish-free form is the only one
that matches, and it survives future tag bumps. Verified: npm install exit 0 with zero
coverage warnings mentioning the dep (was 1).
Also recorded: #2345's lockfile regen fixed a second silent bug (lockfile pinned the
v2.3.0 commit while package.json said v2.4.x — npm ci was shipping the OLD shared
package), and retracted STATUS.md's nonexistent schedulerLease.owner follow-up (the
landed health route already strips the pid for unauthenticated callers; the earlier
observation was against the pre-deploy payload).
Docs updated: STATUS.md, docs/EFFORT-LOG.md,
docs/rollouts/2026-08-02-npm-allowscripts-findings.md (new).
Verified: npx tsc --noEmit clean; plain npm ci exit 0 (575 pkgs); post-change npm install
exit 0, dep coverage warning gone.
Co-Authored-By: Claude <[email protected]>
* docs(handoff): MONET session stop — clean closeout map; board dedupe after merge
Owner-directed stop. Adds the session handoff note (final verified state of all three
arcs: remediation live, deploy pipeline repaired and organically flowing, npm root-caused
with the npm-12-proof key change riding this same PR), updates STATUS.md (prod row:
c117afb is the SECOND organic cutover since the repair; handoff stanza), and the effort
boards. Also merges origin/main into this branch to clear the DIRTY state #2348's squash
left it in, with the union-duplicated effort-log block deduped by hand.
Docs updated: STATUS.md, docs/EFFORT-LOG.md,
docs/rollouts/2026-08-02-monet-session-handoff.md (new).
Co-Authored-By: Claude <[email protected]>
---------
Co-authored-by: Claude <[email protected]>1 parent b7d88e4 commit 8fd6656
5 files changed
Lines changed: 210 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
10 | 17 | | |
11 | 18 | | |
12 | 19 | | |
13 | 20 | | |
14 | 21 | | |
15 | | - | |
| 22 | + | |
16 | 23 | | |
17 | 24 | | |
18 | 25 | | |
| |||
32 | 39 | | |
33 | 40 | | |
34 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
35 | 60 | | |
36 | 61 | | |
37 | 62 | | |
| |||
50 | 75 | | |
51 | 76 | | |
52 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
53 | 81 | | |
54 | 82 | | |
55 | 83 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
1 | 3 | | |
2 | 4 | | |
3 | 5 | | |
| |||
104 | 106 | | |
105 | 107 | | |
106 | 108 | | |
107 | | - | |
108 | 109 | | |
109 | 110 | | |
110 | 111 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
0 commit comments