Warn on modified future frozen string literal - #549
Closed
etiennebarrie wants to merge 11 commits into
Closed
Conversation
|
With byroot suggesting it on the ruby tracker not too long ago, will it be proposed for an upcoming ruby developer meeting as well? |
etiennebarrie
force-pushed
the
warn-on-modified-future-frozen-string-literal
branch
2 times, most recently
from
March 11, 2024 09:44
0b5cb1f to
0b61e41
Compare
|
repro: o = "test"
def o.test
end
o.test |
|
We'll need ruby/prism#2577 to be fully green. |
casperisfine
force-pushed
the
warn-on-modified-future-frozen-string-literal
branch
2 times, most recently
from
March 14, 2024 14:42
db34647 to
b41de40
Compare
|
Alright, we're now at the stage where we're failing on |
casperisfine
force-pushed
the
warn-on-modified-future-frozen-string-literal
branch
3 times, most recently
from
March 14, 2024 21:47
628b631 to
4424995
Compare
Co-authored-by: Jean Boussier <[email protected]>
Co-authored-by: Jean Boussier <[email protected]>
Co-authored-by: Jean Boussier <[email protected]>
Co-authored-by: Jean Boussier <[email protected]>
…fied Co-authored-by: Jean Boussier <[email protected]>
Co-authored-by: Jean Boussier <[email protected]>
Co-authored-by: Jean Boussier <[email protected]>
Co-authored-by: Jean Boussier <[email protected]>
Co-authored-by: Jean Boussier <[email protected]>
casperisfine
force-pushed
the
warn-on-modified-future-frozen-string-literal
branch
from
March 15, 2024 08:54
44fe2c1 to
ab2f29b
Compare
|
Moving to ruby#10262 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.