Skip to content

Conversation

@EvilGenius13
Copy link
Contributor

@EvilGenius13 EvilGenius13 commented Nov 25, 2025

WHY are these changes introduced?

References : #6168

When running theme profile and authenticating with a Theme Access app token, it will return a 500 status code.

WHAT is this pull request doing?

We dot not currently allow theme profiling when using a theme access token. We can revisit this in the future but for now we will return an error saying the command does not work with Theme Access passwords.

Before:
image

After:
image

How to test your changes?

  • Setup an environment that uses a themekit token (tokens start with shptka_)
  • run `theme profile -e <your_env>

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@EvilGenius13 EvilGenius13 requested review from a team as code owners November 25, 2025 16:15
@EvilGenius13 EvilGenius13 force-pushed the theme-profile-messaging-for-themekit branch from bec1ab8 to 87e7f69 Compare November 25, 2025 16:15
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.25% (+0.02% 🔼)
13674/17255
🟡 Branches
73.15% (+0.04% 🔼)
6669/9117
🟡 Functions
79.41% (+0.03% 🔼)
3524/4438
🟡 Lines
79.6% (+0.02% 🔼)
12918/16228
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / admin-as-app.ts
100% 100% 100% 100%
🟢
... / bulk-operation-run-mutation.ts
100% 100% 100% 100%
🟢
... / bulk-operation-run-query.ts
100% 100% 100% 100%
🟢
... / staged-uploads-create.ts
100% 100% 100% 100%
🟢
... / execute-bulk-operation.ts
100% 95.45% 100% 100%
🟢
... / run-mutation.ts
100% 100% 100% 100%
🟢
... / run-query.ts
100% 100% 100% 100%
🟡
... / stage-file.ts
72.73% 62.5% 83.33% 71.88%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / specification.ts
68.52% (-0.57% 🔻)
74.36% (+1.19% 🔼)
76.47% (-1.31% 🔻)
68.09% (-0.66% 🔻)
🟢
... / developer-platform-client.ts
84.62% (-1.5% 🔻)
73.68% (+3.1% 🔼)
81.82% (+1.82% 🔼)
90.63% (-2.71% 🔻)
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
92% (-4% 🔻)
100%
98.33% (-1.67% 🔻)
🔴
... / ui.tsx
50.82% (-0.79% 🔻)
42.86% (-5.53% 🔻)
54.55% (+1.42% 🔼)
50% (-0.82% 🔻)
🟢
... / console.ts
81.82% (+15.15% 🔼)
75% (-25% 🔻)
100% (+33.33% 🔼)
81.82% (+15.15% 🔼)
🔴
... / dev.ts
12.77% (-0.57% 🔻)
2.78% (-0.16% 🔻)
57.14%
12.77% (-0.57% 🔻)
🟡
... / theme-environment.ts
69.57% (-1.86% 🔻)
50%
55.56% (-3.27% 🔻)
69.57% (-1.86% 🔻)

Test suite run success

3379 tests passing in 1380 suites.

Report generated by 🧪jest coverage report action from f688a2b

@EvilGenius13 EvilGenius13 changed the title return an error when using themekit access password with theme profile return an error when using Theme Access password with theme profile Nov 25, 2025
@EvilGenius13 EvilGenius13 force-pushed the theme-profile-messaging-for-themekit branch from 87e7f69 to cf9a602 Compare November 25, 2025 18:30
@EvilGenius13 EvilGenius13 added this pull request to the merge queue Nov 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2025
@EvilGenius13 EvilGenius13 added this pull request to the merge queue Nov 25, 2025
Merged via the queue into main with commit 98e0b13 Nov 25, 2025
25 checks passed
@EvilGenius13 EvilGenius13 deleted the theme-profile-messaging-for-themekit branch November 25, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants