-
Notifications
You must be signed in to change notification settings - Fork 225
[3.86] [Theme] Avoid running cf turnstile in local dev #6538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e catch part is never reached. It should throw and is tested for that
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/fs.d.ts@@ -155,13 +155,6 @@ export declare function mkTmpDir(): Promise<string>;
* @returns True if the path is a directory, false otherwise.
*/
export declare function isDirectory(path: string): Promise<boolean>;
-/**
- * Check whether a path is a directory.
- *
- * @param path - Path to check.
- * @returns True if the path is a directory, false otherwise.
- */
-export declare function isDirectorySync(path: string): boolean;
/**
* Get the size of a file.
*
@@ -280,14 +273,6 @@ export declare function generateRandomNameForSubdirectory(options: GenerateRando
* @returns A promise that resolves to an array of pathnames that match the given pattern.
*/
export declare function glob(pattern: Pattern | Pattern[], options?: GlobOptions): Promise<string[]>;
-/**
- * Synchronously traverse the file system and return pathnames that match the given pattern.
- *
- * @param pattern - A glob pattern or an array of glob patterns.
- * @param options - Options for the glob.
- * @returns An array of pathnames that match the given pattern.
- */
-export declare function globSync(pattern: Pattern | Pattern[], options?: GlobOptions): string[];
/**
* Convert a path to a File URL.
*
packages/cli-kit/dist/public/node/hooks/postrun.d.ts@@ -1,8 +1,2 @@
import { Hook } from '@oclif/core';
-/**
- * Check if post run hook has completed.
- *
- * @returns Whether post run hook has completed.
- */
-export declare function postRunHookHasCompleted(): boolean;
export declare const hook: Hook.Postrun;
\ No newline at end of file
|
Coverage report
Test suite run success3247 tests passing in 1339 suites. Report generated by 🧪jest coverage report action from 12db9e6 |
graygilmore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 this was something we were hoping to get into the release last week
Back-port : #6474