Skip to content

Conversation

@EvilGenius13
Copy link
Contributor

@EvilGenius13 EvilGenius13 commented Oct 20, 2025

Back-port : #6474

@github-actions
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/fs.d.ts
@@ -155,13 +155,6 @@ export declare function mkTmpDir(): Promise<string>;
  * @returns True if the path is a directory, false otherwise.
  */
 export declare function isDirectory(path: string): Promise<boolean>;
-/**
- * Check whether a path is a directory.
- *
- * @param path - Path to check.
- * @returns True if the path is a directory, false otherwise.
- */
-export declare function isDirectorySync(path: string): boolean;
 /**
  * Get the size of a file.
  *
@@ -280,14 +273,6 @@ export declare function generateRandomNameForSubdirectory(options: GenerateRando
  * @returns A promise that resolves to an array of pathnames that match the given pattern.
  */
 export declare function glob(pattern: Pattern | Pattern[], options?: GlobOptions): Promise<string[]>;
-/**
- * Synchronously traverse the file system and return pathnames that match the given pattern.
- *
- * @param pattern - A glob pattern or an array of glob patterns.
- * @param options - Options for the glob.
- * @returns An array of pathnames that match the given pattern.
- */
-export declare function globSync(pattern: Pattern | Pattern[], options?: GlobOptions): string[];
 /**
  * Convert a path to a File URL.
  *
packages/cli-kit/dist/public/node/hooks/postrun.d.ts
@@ -1,8 +1,2 @@
 import { Hook } from '@oclif/core';
-/**
- * Check if post run hook has completed.
- *
- * @returns Whether post run hook has completed.
- */
-export declare function postRunHookHasCompleted(): boolean;
 export declare const hook: Hook.Postrun;
\ No newline at end of file

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.98% 13321/16866
🟡 Branches 72.69% 6509/8955
🟡 Functions 79.17% 3443/4349
🟡 Lines 79.34% 12584/15860

Test suite run success

3247 tests passing in 1339 suites.

Report generated by 🧪jest coverage report action from 12db9e6

@EvilGenius13 EvilGenius13 changed the title Fd fix cf turnstile [3.86] [Theme] Avoid running cf turnstile in local dev Oct 20, 2025
@EvilGenius13 EvilGenius13 marked this pull request as ready for review October 20, 2025 20:45
@EvilGenius13 EvilGenius13 requested review from a team as code owners October 20, 2025 20:45
Copy link
Contributor

@graygilmore graygilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 this was something we were hoping to get into the release last week

@EvilGenius13 EvilGenius13 merged commit 3d06303 into stable/3.86 Oct 20, 2025
2 checks passed
@EvilGenius13 EvilGenius13 deleted the fd-fix-cf-turnstile branch October 20, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants