Skip to content

Conversation

@punkstar
Copy link
Member

@punkstar punkstar commented Oct 7, 2025

Backport #6489 to 3.85.

…rt-for-custom-onsites

Add start_verification_session_url field to custom onsite payments schema
@punkstar punkstar self-assigned this Oct 7, 2025
@punkstar punkstar marked this pull request as ready for review October 7, 2025 16:25
@punkstar punkstar requested a review from a team as a code owner October 7, 2025 16:25
@github-actions

This comment has been minimized.

@punkstar punkstar changed the title [Backport 3.85] Add start_verification_session_url field to custom onsite payments schema [3.85] Add start_verification_session_url field to custom onsite payments schema Oct 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.77% 13727/17427
🟡 Branches 72.48% 6688/9228
🟡 Functions 78.8% 3524/4472
🟡 Lines 79.1% 12976/16404

Test suite run success

3343 tests passing in 1383 suites.

Report generated by 🧪jest coverage report action from de5edbf

@punkstar punkstar requested a review from a team as a code owner October 7, 2025 16:38
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.85.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.85.4";
\ No newline at end of file
packages/cli-kit/dist/public/node/session.d.ts
@@ -6,41 +6,6 @@ export interface AdminSession {
     token: string;
     storeFqdn: string;
 }
-/**
- * Session Object for Partners API and App Management API access.
- */
-export interface Session {
-    token: string;
-    businessPlatformToken: string;
-    accountInfo: AccountInfo;
-    userId: string;
-}
-export type AccountInfo = UserAccountInfo | ServiceAccountInfo | UnknownAccountInfo;
-interface UserAccountInfo {
-    type: 'UserAccount';
-    email: string;
-}
-interface ServiceAccountInfo {
-    type: 'ServiceAccount';
-    orgName: string;
-}
-interface UnknownAccountInfo {
-    type: 'UnknownAccount';
-}
-/**
- * Type guard to check if an account is a UserAccount.
- *
- * @param account - The account to check.
- * @returns True if the account is a UserAccount.
- */
-export declare function isUserAccount(account: AccountInfo): account is UserAccountInfo;
-/**
- * Type guard to check if an account is a ServiceAccount.
- *
- * @param account - The account to check.
- * @returns True if the account is a ServiceAccount.
- */
-export declare function isServiceAccount(account: AccountInfo): account is ServiceAccountInfo;
 /**
  * Ensure that we have a valid session with no particular scopes.
  *
@@ -121,5 +86,4 @@ export declare function ensureAuthenticatedBusinessPlatform(scopes?: BusinessPla
  *
  * @returns A promise that resolves when the logout is complete.
  */
-export declare function logout(): Promise<void>;
-export {};
\ No newline at end of file
+export declare function logout(): Promise<void>;
\ No newline at end of file
packages/cli-kit/dist/public/node/context/fqdn.d.ts
@@ -50,4 +50,4 @@ export declare function identityFqdn(): Promise<string>;
  * @param store - Store name.
  * @returns Normalized store name.
  */
-export declare function normalizeStoreFqdn(store: string): string;
\ No newline at end of file
+export declare function normalizeStoreFqdn(store: string): Promise<string>;
\ No newline at end of file

@punkstar punkstar merged commit 06c6a87 into stable/3.85 Oct 7, 2025
1 check passed
@punkstar punkstar deleted the punkstar/allow-verification-start-for-custom-onsites-backport-3.85 branch October 7, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant