Fix dev stores with custom domains #6430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success3228 tests passing in 1336 suites. Report generated by 🧪jest coverage report action from ccbd42a |
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]Caution After installing, validate the version by running just |
plvaldes
approved these changes
Oct 3, 2025
gonzaloriestra
approved these changes
Oct 3, 2025
isaacroldan
force-pushed
the
09-25-fix_dev_stores_with_custom_domains
branch
from
c79edca to
ccbd42a
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/context/fqdn.d.ts@@ -50,4 +50,4 @@ export declare function identityFqdn(): Promise<string>;
* @param store - Store name.
* @returns Normalized store name.
*/
-export declare function normalizeStoreFqdn(store: string): Promise<string>;
\ No newline at end of file
+export declare function normalizeStoreFqdn(store: string): string;
\ No newline at end of file
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
To fix an issue where store domains were not being properly normalized when fetched from the Business Platform API.
WHAT is this pull request doing?
urlfield to the GraphQL query for listing app development storesmapBusinessPlatformStoresToOrganizationStoresfunction to use the normalized URL from the store datanormalizeStoreFqdnfunction to handle URLs with/adminpathsnormalizeStoreFqdnsynchronous since it no longer needs to be asyncHow to test your changes?
shopify app devwith a store that has a custom primary domainMeasuring impact
How do we know this change was effective? Please choose one:
Checklist