Clean up POLARIS_UNIFIED flag #6421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dmerand
reviewed
Sep 22, 2025
Contributor
dmerand
left a comment
dmerand
left a comment
There was a problem hiding this comment.
Is it worth also removing is-polaris-unified-enabled.ts as it's also no longer used after this change?
Contributor
Author
|
Yea, good call out |
Fionoble
force-pushed
the
fio/trish/cleanup-polaris-flag
branch
3 times, most recently
from
2c60706 to
f72f890
Compare
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success3328 tests passing in 1382 suites. Report generated by 🧪jest coverage report action from e81c29c |
vividviolet
approved these changes
Sep 24, 2025
| }) | ||
|
|
||
| test('excludes the preact flavor by default', async () => { | ||
| test('includes all flavors including preact', async () => { |
Member
There was a problem hiding this comment.
Let's just delete these tests - they are meaningless now. We just pass through all flavors which is already covered by the other tests
Merged
2 tasks
vividviolet
force-pushed
the
fio/trish/cleanup-polaris-flag
branch
from
f72f890 to
ad36509
Compare
Member
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
vividviolet
added a commit
to Shopify/extensions-templates
that referenced
this pull request
Sep 25, 2025
### Background Add a new template for "admin.customers.segmentation-templates.data" ### 🎩 1. Checkout this PR on the CLI Shopify/cli#6421 2. In the CLI repo, open `packages/cli-kit/src/public/common/version.ts` and update `CLI_KIT_VERSION` ```ts export const CLI_KIT_VERSION = '3.85.0' ``` 3. In the CLI repo, open `packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts` and update `TEMPLATE_JSON_URL` ```ts const TEMPLATE_JSON_URL = 'https://raw.githubusercontent.com/Shopify/extensions-templates/500a2fc24ebb89635f8c7ccff21e812db2cd1e6e/templates.json' ``` 4. Run `pnpm shopify app generate extension --path=<path-to-your-app> --clone-url https://github.com/Shopify/extensions-templates#Add_Customer_Segment_Template_data_extension` 5. Verify you're able to create new data extension for customer segment ### Checklist - [x] I have 🎩'd these changes - [ ] I have squashed my commits into chunks of work with meaningful commit messages
Fionoble
force-pushed
the
fio/trish/cleanup-polaris-flag
branch
from
ad36509 to
6767e9f
Compare
vividviolet
approved these changes
Sep 26, 2025
We will always want a tsconfig so we can type the shopify global
vividviolet
force-pushed
the
fio/trish/cleanup-polaris-flag
branch
from
6767e9f to
602abeb
Compare
2 tasks
isaacroldan
approved these changes
Sep 29, 2025
Contributor
isaacroldan
left a comment
isaacroldan
left a comment
There was a problem hiding this comment.
Didn't 🎩 but code looks good
dmerand
approved these changes
Sep 29, 2025
…for_ui_extensions Remove code to delete the tsconfig for ui extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes all logic related to the "Polaris Unified" early access feature from the CLI codebase. The main impact is that options and filtering based on the
POLARIS_UNIFIEDenvironment variable or theisPolarisUnifiedEnabledflag are no longer present, simplifying the code and standardizing available templates for all users.Removal of Polaris Unified feature flag logic:
javascriptPolarisEarlyAccessandtypescriptPolarisEarlyAccessoptions are no longer conditionally included in thetemplatesobject ininit.ts, so users will not see Polaris Release Candidate template branches.POLARIS_UNIFIEDenvironment variable or uses theisPolarisUnifiedEnabledfunction to filter template flavors (such as only showingpreactwhen enabled) is removed fromfetch-template-specifications.ts, resulting in consistent template filtering regardless of environment.