Improve shopify theme dev to prevent accidental updates to live themes
#6314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Coverage report
Show files with reduced coverage 🔻
Test suite run success3236 tests passing in 1354 suites. Report generated by 🧪jest coverage report action from 0d0c8b1 |
EvilGenius13
approved these changes
Aug 25, 2025
Contributor
There was a problem hiding this comment.
Thank you for the extra guard @karreiro!
🎩 went well
aswamy
approved these changes
Aug 25, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/developer-tools-team/issues/741
WHAT is this pull request doing?
This PR updates
shopify theme devto ask for confirmation before running the command with a live theme.How to test your changes?
shopify theme dev -t <live_theme_id>Before:
After:
Post-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
Checklist