Skip to content
This repository was archived by the owner on Aug 30, 2018. It is now read-only.

Add Apple wallet button to gift card template#476

Merged
blboyle merged 1 commit into
masterfrom
add-passbook
Oct 21, 2015
Merged

Add Apple wallet button to gift card template#476
blboyle merged 1 commit into
masterfrom
add-passbook

Conversation

@blboyle

@blboyle blboyle commented Oct 21, 2015

Copy link
Copy Markdown
Contributor

I made the updates for adding the Apple wallet button to the gift card template, to account for Apple's wallet, and showing the QR code all the time, instead of only on print.

@ohsabry can you check this out for me?

@ohsabry

ohsabry commented Oct 21, 2015

Copy link
Copy Markdown

Thanks. Code looks fine, is there any way I can 🎩 ?

@blboyle blboyle self-assigned this Oct 21, 2015
@blboyle

blboyle commented Oct 21, 2015

Copy link
Copy Markdown
Contributor Author

This seems like it works, but we don't see the Apple wallet button for some reason.

https://checkout.shopify.com/gift_cards/10007292/preview this should show you the example of the new gift card page in my test store.

@cshold

cshold commented Oct 21, 2015

Copy link
Copy Markdown
Contributor

👍

@ohsabry

ohsabry commented Oct 21, 2015

Copy link
Copy Markdown

@blboyle Sorry, a few gotchas

One is that the beta flag name was changed from passbook to apple_pass.

The other is that non alphanumeric characters other than spaces are currently not allowed for the pass title, and your shop name has an exclamation point. I'll fix that today.

The last one is that you button won't download a pass if the shop is password protected.

I was able to go into your shop, add the new beta flag, enable apple wallet, and get it to appear:
https://checkout.shopify.com/gift_cards/10007292/cd7c26541fb53b0b64b4bc9ce11cc66c

blboyle added a commit that referenced this pull request Oct 21, 2015
Add Apple wallet button to gift card template
@blboyle blboyle merged commit 04c96e7 into master Oct 21, 2015
@blboyle blboyle deleted the add-passbook branch October 21, 2015 20:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants