This repository was archived by the owner on Aug 30, 2018. It is now read-only.
Conversation
|
Should the prices in the search grid be updates also? |
Contributor
Author
|
@suture definitely, thanks for catching. I've added that in the latest commit. |
Contributor
Author
|
Ping for a 👍 @stevebosworth @mpiotrowicz |
Contributor
|
Looks good 👍 |
cshold
added a commit
that referenced
this pull request
Mar 2, 2015
Updated product sale presentation in grid/list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the product grid/list item snippets and search results to use a more readable sale prices.
Now there are three ways to show the price:
Fixes #209
I've also slightly updated the list item layout so that the price never breaks below the product image.
Thoughts, @stevebosworth @jholl @tranhelen @graygilmore?