Repository navigation
Commit 54a5d33
fix: Avoid ON TRUE and multiple USING joins in the ClickHouse point-in-time join
ClickHouse's old analyzer (the default before 24.3, and still used with
enable_analyzer = 0) rejects two joins in the point-in-time join template:
- `ON TRUE AND subquery.k = entity_dataframe.k` fails with
INVALID_JOIN_ON_EXPRESSION ("Illegal expression 'true' in JOIN ON
section"), for every query.
- The final SELECT joins each feature view back with USING, and with two
or more feature views it fails with "Code: 48. Multiple USING
statements are not supported".
Join the entity keys with `ON k1 = k1 AND k2 = k2`, use CROSS JOIN for a
feature view without entities (it only had `ON TRUE`), and join the
feature views back with `ON "<fv>"."<fv>__entity_row_unique_id" =
entity_dataframe."<fv>__entity_row_unique_id"`.
Fixes feast-dev#6141
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012XPuJeHi7A5CeHSKHjHmwx
Signed-off-by: Shivam Sharma <[email protected]>1 parent 171d601 commit 54a5d33
2 files changed
Lines changed: 110 additions & 3 deletions
File tree
- sdk/python
- feast/infra/offline_stores/contrib/clickhouse_offline_store
- tests/unit/infra/offline_stores
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
532 | 532 | | |
533 | 533 | | |
534 | 534 | | |
| 535 | + | |
535 | 536 | | |
536 | | - | |
| 537 | + | |
537 | 538 | | |
538 | | - | |
| 539 | + | |
539 | 540 | | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
540 | 544 | | |
541 | 545 | | |
542 | 546 | | |
| |||
625 | 629 | | |
626 | 630 | | |
627 | 631 | | |
628 | | - | |
| 632 | + | |
| 633 | + | |
629 | 634 | | |
630 | 635 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
240 | 240 | | |
241 | 241 | | |
242 | 242 | | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
0 commit comments