further fixes for in installer batch script when NASM or its installer files are already present on the machine.#30
Merged
Sibras merged 1 commit intoShiftMediaProject:masterfrom Mar 1, 2025
Conversation
- typo fix in comment - At least on some Win10 machines, attempting to execute a *non-existent* `"%NASMPATH%\nasm.exe"` will cause the subsequent `%ERRORLEVEL% equ 0` check to **pass** inadvertently, hence we MUST first check whether the indicated nasm.exe exists, truly, before running this version test/check in the installer batch script. - At least on Win10, when NASM had already been previously installed using the standard Windows NASM installer application, the path to the nasm.exe WILL contain spaces (`C:/Program Files...`) and we must make sure our installer batch script correctly deals with this scenario, requiring paths to be surrounded by `"` double quotes. - Expanded the error/progress messages in the installer batch script a bit to make them more useful and legible when the `NASMPATH` environment variable has not been set up or is (probably erroneously) *empty*: now at least one of the installer progress messages allows the user to diagnose this scenario.
Contributor
Author
|
I believe this also takes care of #28, BTW. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the commit message, the fixes:
"%NASMPATH%\nasm.exe"will cause the subsequent%ERRORLEVEL% equ 0check to pass inadvertently, hence we MUST first check whether the indicated nasm.exe exists, truly, before running this version test/check in the installer batch script.C:/Program Files...) and we must make sure our installer batch script correctly deals with this scenario, requiring paths to be surrounded by"double quotes.NASMPATHenvironment variable has not been set up or is (probably erroneously) empty: now at least one of the installer progress messages allows the user to diagnose this scenario.These fixes were necessary to complete the installer script when the NASM files were already present/installed on two fresh Win10 dev machine installs (thanks to a catastrophic failure, I had to install everything from scratch and our in-house procedure already fetched the latest NASM binary before we got to the stage where we installed VSNASM. (Redacted) sysinfo:
Plus latest MSVC2022 version installed (Microsoft Visual Studio Community 2022 (64-bit) - Current Version 17.13.1)