Improve checking for existing NASM instance#28
Closed
TracerDS wants to merge 1 commit intoShiftMediaProject:masterfrom
TracerDS:patch-1
Closed
Improve checking for existing NASM instance#28TracerDS wants to merge 1 commit intoShiftMediaProject:masterfrom TracerDS:patch-1
TracerDS wants to merge 1 commit intoShiftMediaProject:masterfrom
TracerDS:patch-1
Conversation
Improved checking for existing NASM instance.
It will now properly checks in folders with spaces and special characters without needing quotation marks ("")
Member
|
merged #30 which fixes this aswell, thanks anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will now properly checks in folders with spaces and special characters without needing quotation marks ("").
Basically, this change doesnt force the user to set the
NASMPATHvariable to the path with surrounding quotes: