You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 4e3a2e9
Browse filesBrowse the repository at this point in the historyBrowse files
Related to flutter#184950
This PR is to remove the legacy `gen-defaults-names` and
`gen-defaults-up-to-date` analyze checks from Flutter CI.
These checks validate `dev/tools/gen_defaults`, which has become legacy
and only targets the frozen SDK Material library under
`packages/flutter/lib/src/material`. Material development has moved to
the standalone `material_ui` packages in `flutter/packages`, and we
introduced new `gen_defaults` script in flutter/packages, so these check
for old script is not useful at all.
This PR also removes the now-unused helper methods and their test
coverage.
TODO: the old `gen_defaults` tool should eventually be deprecated and
removed.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
// Compare the generated code before and after running gen_defaults.dart.
551
-
for (finalString fileName in beforeGeneratedCode.keys) {
552
-
finalList<String> before = beforeGeneratedCode[fileName]!;
553
-
finalList<String> after = afterGeneratedCode[fileName]!;
554
-
if (!constIterableEquality<String>().equals(before, after)) {
555
-
errors.add('$fileName is not up-to-date with the token template file.');
556
-
}
557
-
}
558
-
559
-
// Fail if any errors.
560
-
if (errors.isNotEmpty) {
561
-
foundError(<String>[
562
-
...errors,
563
-
'${bold}See: https://github.com/flutter/flutter/blob/main/dev/tools/gen_defaults to update the token template files.$reset',
564
-
]);
565
-
}
566
-
}
567
-
568
425
/// Verify tool test files end in `_test.dart`.
569
426
///
570
427
/// The test runner will only recognize files ending in `_test.dart` as tests to
0 commit comments