Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

Added support for /_api/web/getsubwebsfilteredforcurrentuser#599

Merged
patrick-rodgers merged 5 commits intoSharePoint:devfrom
gautamdsheth:master
Sep 20, 2017
Merged

Added support for /_api/web/getsubwebsfilteredforcurrentuser#599
patrick-rodgers merged 5 commits intoSharePoint:devfrom
gautamdsheth:master

Conversation

@gautamdsheth
Copy link
Copy Markdown
Contributor

Q A
Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues? mentioned in #593

What's in this Pull Request?

Adding support for /_api/web/getsubwebsfilteredforcurrentuser. Usually the /_api/web/webs gives access denied for users having read permission only. Using this endpoint fetch the sub webs to current user has access.

@msftclas
Copy link
Copy Markdown

@gautamdsheth,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Copy link
Copy Markdown
Contributor

@patrick-rodgers patrick-rodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition looks good - but it also looks like you copied webs.ts to the project root so I can't merge this as is. Can you remove the extra file?

Copy link
Copy Markdown
Contributor

@patrick-rodgers patrick-rodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And on second look I think you want to use .clone of Webs so you can keep any batch, etc.

@gautamdsheth
Copy link
Copy Markdown
Contributor Author

@patrick-rodgers - ahh bummer, removed that extra file i added by mistake. Also added the clone of .Webs. Thanks for reviewing and getting back so quickly 👍

Copy link
Copy Markdown
Contributor

@patrick-rodgers patrick-rodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patrick-rodgers patrick-rodgers merged commit 808fbf5 into SharePoint:dev Sep 20, 2017
@patrick-rodgers
Copy link
Copy Markdown
Contributor

Thanks, appreciate the contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants