This repository was archived by the owner on Aug 28, 2024. It is now read-only.
config.hasOwnProperty check "spFXContext" string replaced by "spfxContext"#419
Merged
patrick-rodgers merged 1 commit intoSharePoint:devfrom Apr 18, 2017
Merged
config.hasOwnProperty check "spFXContext" string replaced by "spfxContext"#419patrick-rodgers merged 1 commit intoSharePoint:devfrom
patrick-rodgers merged 1 commit intoSharePoint:devfrom
Conversation
Small bug fix related to issue SharePoint#411 The upper letters "FX" in config.hasOwnProperty("spFXContext ") check were the reason the pnp.setup not to pick the custom spfxContext for a spfx webpart.
|
@VelinGeorgiev, |
Contributor
|
Great find, thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upper letters "FX" in config.hasOwnProperty("spFXContext ") check in file src/configuration/pnplibconfig.ts were the reason the pnp.setup not to pick the custom spfxContext for spfx webpart.
What's in this Pull Request?
Small bug fix related to issue #411