update to items.add to allow passing of the ListItemEntityTypeName to save on calls when adding multiple items

patrick-rodgers · patrick-rodgers · commit eb96952668e6 · 2017-01-13T13:50:28.000-05:00
diff --git a/src/sharepoint/items.ts b/src/sharepoint/items.ts
@@ -8,6 +8,7 @@ import { Util } from "../utils/util";
 import * as Types from "./types";
 import { ODataParserBase } from "./odata";
 import { AttachmentFiles } from "./attachmentfiles";
+import { List } from "./lists";
 
 /**
  * Describes a collection of Item objects
@@ -58,29 +59,42 @@ export class Items extends QueryableCollection {
      *
      * @param properties The new items's properties
      */
-    public add(properties: TypedHash<any> = {}): Promise<ItemAddResult> {
+    public add(properties: TypedHash<any> = {}, listItemEntityTypeFullName: string = null): Promise<ItemAddResult> {
 
-        let removeDependency = this.addBatchDependency();
-
-        let parentList = this.getParent(QueryableInstance);
-
-        return parentList.select("ListItemEntityTypeFullName").getAs<{ ListItemEntityTypeFullName: string }>().then((d) => {
+        let doAdd = (listItemEntityType: string): Promise<ItemAddResult> => {
 
             let postBody = JSON.stringify(Util.extend({
-                "__metadata": { "type": d.ListItemEntityTypeFullName },
+                "__metadata": { "type": listItemEntityType },
             }, properties));
 
-            let promise = this.postAs<{ Id: number }>({ body: postBody }).then((data) => {
+            return this.postAs<{ Id: number }>({ body: postBody }).then((data) => {
                 return {
                     data: data,
                     item: this.getById(data.Id),
                 };
             });
 
-            removeDependency();
+        }
 
-            return promise;
-        });
+        if (!listItemEntityTypeFullName) {
+
+            let parentList = this.getParent(List);
+
+            let removeDependency = this.addBatchDependency();
+
+            return parentList.getListItemEntityTypeFullName().then(n => {
+
+                let promise = doAdd(n);
+
+                removeDependency();
+
+                return promise;
+            });
+
+        } else {
+
+            return doAdd(listItemEntityTypeFullName);
+        }
     }
 }
 
diff --git a/src/sharepoint/lists.ts b/src/sharepoint/lists.ts
@@ -422,6 +422,15 @@ export class List extends QueryableSecurable {
             }
         });
     }
+
+    /**
+     * Returns the ListItemEntityTypeFullName for this list, used when adding/updating list items
+     * 
+     */
+    public getListItemEntityTypeFullName(): Promise<string> {
+
+        return this.select("ListItemEntityTypeFullName").getAs<{ ListItemEntityTypeFullName: string }>().then(o => o.ListItemEntityTypeFullName);
+    }
 }
 
 export interface ListAddResult {

Original file line number	Diff line number	Diff line change
`@@ -422,6 +422,15 @@ export class List extends QueryableSecurable {`
`422`	`422`	`}`
`423`	`423`	`});`
`424`	`424`	`}`
	`425`	`+`
	`426`	`+ /**`
	`427`	`+ * Returns the ListItemEntityTypeFullName for this list, used when adding/updating list items`
	`428`	`+ *`
	`429`	`+ */`
	`430`	`+ public getListItemEntityTypeFullName(): Promise<string> {`
	`431`	`+`
	`432`	`+ return this.select("ListItemEntityTypeFullName").getAs<{ ListItemEntityTypeFullName: string }>().then(o => o.ListItemEntityTypeFullName);`
	`433`	`+ }`
`425`	`434`	`}`
`426`	`435`
`427`	`436`	`export interface ListAddResult {`