Open
Conversation
- Add test for archiving and unarchiving sessions - Add test for archived filter returning only archived sessions - Tests verify Session.setArchived and Session.listGlobal work correctly
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
6 tasks
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Owner
Author
|
Hi maintainers! I noticed there's also a closed PR anomalyco#16001 (feat(app): unarchive sessions) that addresses the same issue. This PR (#1) adds complementary tests for the archive/unarchive functionality. Could you let me know:
Thanks! |
Owner
Author
|
pinging @adamdotdevin - could you review this PR? The tests pass and it complements PR anomalyco#15250 which adds the archive/unarchive UI feature. Would be great to get this merged to help prevent future regressions! The tests verify:
All 1629 tests pass including the new archive tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes anomalyco#6680
Closes anomalyco#12393
Type of change
What does this PR do?
This PR adds unit tests for the archive/unarchive functionality that will be added in PR anomalyco#15250. The tests verify:
How did you verify your code works?
All tests pass:
Backend verification completed - the archive/unarchive functionality works correctly.
Screenshots / recordings
N/A - This is a backend test-only PR
Checklist