Skip to content

Feature/push docker hub#142

Merged
PauloGoncalvesBH merged 6 commits intoServeRest:betafrom
eliasreis54:feature/push-dockerHub
Oct 2, 2020
Merged

Feature/push docker hub#142
PauloGoncalvesBH merged 6 commits intoServeRest:betafrom
eliasreis54:feature/push-dockerHub

Conversation

@eliasreis54
Copy link
Copy Markdown
Contributor

@eliasreis54 eliasreis54 commented Oct 2, 2020

Description

First attempt to push image on docker hub after build pass

@PauloGoncalvesBH could you check if is there something wrong?

after check If it is right and publish the image we can return the semantic-release plugins.

How can the user experience this change?

Merge this PR in the beta branch`

Documentation

Related Issues

This is related to # 47, but is only a try.

PR Tasks

  • Has been related to an issue?
  • Have tests been added/updated?
  • Has Aglio documentation been added/updated?

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #142 into beta will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              beta      #142   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          382       382           
=========================================
  Hits           382       382           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 814444a...2258270. Read the comment docs.

@PauloGoncalvesBH
Copy link
Copy Markdown
Member

@eliasreis54 vou fazer o rebase pra fazermos o teste da entrega contínua da imagem.

@PauloGoncalvesBH PauloGoncalvesBH merged commit 28ddd86 into ServeRest:beta Oct 2, 2020
@eliasreis54
Copy link
Copy Markdown
Contributor Author

Show! Estou na torcida aqui! hahah

@PauloGoncalvesBH
Copy link
Copy Markdown
Member

@eliasreis54 ish, o log mostra que não foi encontrado necessidade de gerar nova release.
Acabei de analisar a alteração e fiz que eu sugeri coisa errada.
Tem que incluir o seguinte plugin para funcionar, pois é ele que analisa as mensagens de commit.

Irei fazer o ajuste na branch beta e acompnhar a pipeline de entrega contínua que será triggada.

    ['@semantic-release/commit-analyzer', {
      releaseRules: [
        { type: 'docs', scope: 'readme', release: 'patch' },
        { scope: 'no-release', release: false }
      ]
    }],

@eliasreis54
Copy link
Copy Markdown
Contributor Author

Bacana @PauloGoncalvesBH estou acompanhando aqui também.
Legal que to aprendendo várias coisas sobre o semantic-release
Se precisar que faça algo, só falar.

@eliasreis54
Copy link
Copy Markdown
Contributor Author

@PauloGoncalvesBH acho que a tag no docker hub precisa tudo lowercase.
Pelo que está no log: invalid reference format: repository name must be lowercase

@PauloGoncalvesBH
Copy link
Copy Markdown
Member

pois é, vou fazer esse ajuste aqui

@PauloGoncalvesBH PauloGoncalvesBH linked an issue Oct 2, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disponibilizar no docker hub

3 participants