Support 'Involved People List' Id3v2 frame#215
Merged
Serial-ATA merged 12 commits intoSerial-ATA:mainfrom Jul 5, 2023
Merged
Conversation
added 2 commits
July 2, 2023 15:09
- change doc comments on KeyValueFrame
FriederHannenheim
force-pushed
the
TIPL_support
branch
from
3836057 to
bdcf007
Compare
Contributor
|
I suggest to add a round trip test (write -> read -> verify) an ID3v2 tag that contains a |
Serial-ATA
requested changes
Jul 2, 2023
Co-authored-by: Alex <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: Alex <[email protected]>
Author
|
Thanks for your suggestions. I've implemented the requested changes and tried to create a test, however the test is failing. I don't know why. Could one of you maybe take a look? |
Serial-ATA
requested changes
Jul 3, 2023
added 2 commits
July 4, 2023 18:49
Author
|
I've fixed the test |
Owner
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #213