feat: Add ExcludeFromCodeCoverage attribute to embedded resources#63
Merged
Conversation
Sergio0694
requested changes
May 14, 2023
Sergio0694
left a comment
Sergio0694
left a comment
Owner
There was a problem hiding this comment.
Mmh actually I'm not entirely sure this should be merged. The [ExcludeFromCodeCoverage] attribute is only available since .NET Framework 4.0, whereas PolySharp currently supports down to .NET Framework 3.5. I'll need to think about this and see if there's a workaround 🤔
Owner
|
This should do the trick, need to validate this first before merging this 🙂 |
Sergio0694
approved these changes
May 15, 2023
Sergio0694
left a comment
Sergio0694
left a comment
Owner
There was a problem hiding this comment.
Pushed another small fix and validated on .NET Framework 3.5, all good!
Thank you! 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62