Hey @cremor, I'm having trouble setting up a local packages.config project to validate this. If you have time, could you try getting the package from the build artifacts here (you can find it here) and see if you correctly get the warning? Thank you! 🙂

Not getting any warning in my sample project: ConsoleApp1.zip

But I think I added it correctly because after using the VS feature to convert packages.config to <PackageReference> the files are generated correctly.

Is the implication here that consuming applications would be encouraged to migrate away from the use of a packages.config file and towards the use of <PackageReference/>s in their .csproj project files?

Yes. Source generators just don't seem to work at all with packages.config, so I don't think they'd have much of a choice 😅
Other than, of course, not using PolySharp at all. But also, packages.config is just terrible, so not a great loss ahah

Alrighty then! I'll annotate that on my unit test repo for future reference. :)

It's fine with me, since NuGet restore in Azure Devops pipelines seems to have a problem restoring packages from a Packages.config for project references anyway. So I'm with you.

Hey @cremor, I've updated the .targets file with new logic to check for packages.config, it should work correctly now 😄