Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Sidebar): fix a collision between children and shorthand props #4145

Merged
merged 3 commits into from
Jan 19, 2021
Merged

fix(Sidebar): fix a collision between children and shorthand props #4145

merged 3 commits into from
Jan 19, 2021

Conversation

layershifter
Copy link
Member

Fixes #4098.

@github-actions
Copy link

size-limit report

Path Size
bundle-size/dist/Button.size.js 58.58 KB (0%)
bundle-size/dist/Icon.size.js 25.06 KB (0%)
bundle-size/dist/Image.size.js 53.76 KB (0%)
bundle-size/dist/Modal.size.js 68.66 KB (0%)
bundle-size/dist/Portal.size.js 40.46 KB (0%)

@codecov-io
Copy link

Codecov Report

Merging #4145 (8b1ef8d) into master (cb4b05e) will decrease coverage by 80.96%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4145       +/-   ##
===========================================
- Coverage   99.75%   18.79%   -80.97%     
===========================================
  Files         180      180               
  Lines        3241     3241               
===========================================
- Hits         3233      609     -2624     
- Misses          8     2632     +2624
Impacted Files Coverage Δ
src/modules/Sidebar/Sidebar.js 100.00% <ø> (ø)
src/modules/Transition/utils/wrapChild.js 0.00% <0.00%> (-100.00%) ⬇️
src/addons/Portal/utils/validateTrigger.js 0.00% <0.00%> (-100.00%) ⬇️
src/modules/Dropdown/utils/getMenuOptions.js 0.00% <0.00%> (-100.00%) ⬇️
src/modules/Dropdown/utils/getSelectedIndex.js 0.00% <0.00%> (-100.00%) ⬇️
src/behaviors/Visibility/Visibility.js 2.15% <0.00%> (-97.85%) ⬇️
src/modules/Dropdown/Dropdown.js 2.66% <0.00%> (-97.34%) ⬇️
src/modules/Sticky/Sticky.js 1.83% <0.00%> (-97.25%) ⬇️
src/modules/Progress/Progress.js 2.77% <0.00%> (-97.23%) ⬇️
src/modules/Search/Search.js 3.52% <0.00%> (-96.04%) ⬇️
... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb4b05e...c83117d. Read the comment docs.

@layershifter layershifter merged commit 89ba138 into master Jan 19, 2021
@layershifter layershifter deleted the fix/sidebar-children branch January 19, 2021 16:21
@layershifter layershifter mentioned this pull request Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prop items in Menu conflicts with props: children
2 participants
@layershifter @codecov-io