-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use react-intersection-observer
in docs to improve perf
#3985
chore: use react-intersection-observer
in docs to improve perf
#3985
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3985 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 181 180 -1
Lines 3168 3169 +1
=======================================
+ Hits 3163 3164 +1
Misses 5 5
Continue to review full report at Codecov.
|
react-intersection-observer
in docs to improve perf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed few more changes, LGTM. Also verified SSR scenario for docs, works as expected
Thanks ❤️
Fixes #3978.
Added react intersection observer to docs component examples to improve cpu usage over getBoundingRect function call. Replaced react visibility sensor.