Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FormFiled): pass id when contains child elements or has content prop #3901

Merged
merged 5 commits into from
Jul 24, 2020

Conversation

srotbart
Copy link
Contributor

@srotbart srotbart commented Feb 24, 2020

Fixes #3900

Fixed issue where ID cannot be set when contains child elements or content props for FormField

@welcome
Copy link

welcome bot commented Feb 24, 2020

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #3901 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3901      +/-   ##
==========================================
+ Coverage   99.84%   99.84%   +<.01%     
==========================================
  Files         178      178              
  Lines        3150     3151       +1     
==========================================
+ Hits         3145     3146       +1     
  Misses          5        5
Impacted Files Coverage Δ
src/collections/Form/FormField.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dbab6b...bcf4ca5. Read the comment docs.

@srotbart
Copy link
Contributor Author

@levithomason
Hi Levi, could you please address this PR?

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2020

Codecov Report

Merging #3901 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3901   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         183      183           
  Lines        3157     3157           
=======================================
  Hits         3152     3152           
  Misses          5        5           
Impacted Files Coverage Δ
src/collections/Form/FormField.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c2ce4...d3563af. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview July 24, 2020 10:53 Inactive
@layershifter layershifter changed the title Fixed - Form.Field - Cannot set ID when contains child elements or content prop fix(FormFiled): pass id when contains child elements or has content prop Jul 24, 2020
@layershifter
Copy link
Member

I was a bit confused with a use case for this as according to spec input elements should have id (https://www.w3.org/TR/WCAG20-TECHS/H44.html) to be linked with labels. However, at the same time it's frustrating that id is passed nowhere.

Thanks for addressing this 👍

@welcome
Copy link

welcome bot commented Jul 24, 2020

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form.Field - Cannot set ID when contains child elements or content prop
5 participants