-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FormFiled): pass id
when contains child elements or has content
prop
#3901
Conversation
…ld elements were provided
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #3901 +/- ##
==========================================
+ Coverage 99.84% 99.84% +<.01%
==========================================
Files 178 178
Lines 3150 3151 +1
==========================================
+ Hits 3145 3146 +1
Misses 5 5
Continue to review full report at Codecov.
|
@levithomason |
Codecov Report
@@ Coverage Diff @@
## master #3901 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 183 183
Lines 3157 3157
=======================================
Hits 3152 3152
Misses 5 5
Continue to review full report at Codecov.
|
id
when contains child elements or has content
prop
I was a bit confused with a use case for this as according to spec input elements should have Thanks for addressing this 👍 |
Fixes #3900
Fixed issue where ID cannot be set when contains child elements or content props for FormField