feat(Popup): add popperDependencies prop
#3657
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3657 +/- ##
==========================================
+ Coverage 99.81% 99.81% +<.01%
==========================================
Files 174 174
Lines 2749 2755 +6
==========================================
+ Hits 2744 2750 +6
Misses 5 5
Continue to review full report at Codecov.
|
src/modules/Popup/Popup.js
Outdated
| @@ -171,6 +177,12 @@ export default class Popup extends Component { | |||
| return { contentRestProps, portalRestProps } | |||
| } | |||
|
|
|||
| componentDidUpdate(prevProps) { | |||
| if (this.open && shallowEqual(this.props.popperDependencies, prevProps.popperDependencies)) { | |||
There was a problem hiding this comment.
shallowEqual for dependency prop doesn't fit to hook-like dependency input.
React hook uses internal areHookInputsEqual(nextDeps, prevDeps) methods which iteratively check both input items using Object.is() in order.
And there is a clone of above method in npm GitHub:
https://github.com/Andarist/are-hook-inputs-equal/blob/master/src/index.js
Sorry, I found that the shallowequal library already do that! 😅
There was a problem hiding this comment.
I will cover this with UTs to be sure 🐱
Co-Authored-By: Youngrok Kim <[email protected]>
* feat(Popup): add `popperDependencies` prop * Update src/modules/Popup/Popup.js Co-Authored-By: Youngrok Kim <[email protected]> * add UTs, fix condition * simplify implemention
Fixes #3639.
This PR adds
popperDependenciesthat behaves like dependencies in React Hooks and allows to schedule a position update forPopup. Should be used in cases when content is changing.