Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Examples): reduce number of items in examples, fix HMR issues #3651

Merged
merged 2 commits into from
Jun 9, 2019

Conversation

layershifter
Copy link
Member

This PR:

  • updates Select example and Dropdown example to reduce number of rendered items, it will make editor more smoothly, fixes Docs: performance problems in docs for Select #3643
  • updates react-source-render & adds fixes to ComponentExample to fix issues with HMR during local development

@codecov-io
Copy link

Codecov Report

Merging #3651 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3651      +/-   ##
==========================================
- Coverage   99.81%   99.81%   -0.01%     
==========================================
  Files         174      174              
  Lines        2747     2743       -4     
==========================================
- Hits         2742     2738       -4     
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Modal/Modal.js 100% <0%> (ø) ⬆️
src/modules/Popup/lib/createReferenceProxy.js 100% <0%> (ø) ⬆️
src/modules/Dropdown/Dropdown.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3abc92...abeaf7e. Read the comment docs.

@layershifter layershifter merged commit 5db5f09 into master Jun 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the docs/improve-perf branch June 9, 2019 10:51
mbakiev pushed a commit to mbakiev/Semantic-UI-React that referenced this pull request Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: performance problems in docs for Select
2 participants