Skip to content

Update docker configuration section in documentation#1011

Merged
diemol merged 2 commits intoSeleniumHQ:trunkfrom
gifflet:add_docker_device_mapping
May 23, 2022
Merged

Update docker configuration section in documentation#1011
diemol merged 2 commits intoSeleniumHQ:trunkfrom
gifflet:add_docker_device_mapping

Conversation

@gifflet
Copy link
Copy Markdown
Contributor

@gifflet gifflet commented May 16, 2022

Description

Update docker configuration section in documentation

Motivation and Context

This PR is the documentation of SeleniumHQ/selenium#10645.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@gifflet gifflet mentioned this pull request May 16, 2022
Merged
8 tasks
@netlify
Copy link
Copy Markdown

netlify Bot commented May 16, 2022 •
edited
Loading

✅ Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit 42d3b88
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/628b8c1aacbc280008baa12d
😎 Deploy Preview https://deploy-preview-1011--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

diemol
diemol requested changes May 23, 2022
View reviewed changes
Comment thread website_and_docs/content/documentation/grid/configuration/toml_options.ja.md
diemol
diemol previously approved these changes May 23, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dilhelh!

@diemol
Copy link
Copy Markdown
Member

diemol commented May 23, 2022

Can you please rebase so I can merge?

@gifflet
Copy link
Copy Markdown
Contributor Author

gifflet commented May 23, 2022

Branch updated

@diemol diemol merged commit 78dc23e into SeleniumHQ:trunk May 23, 2022
selenium-ci added a commit that referenced this pull request May 23, 2022
@selenium-ci
Update docker configuration section in documentation (#1011)
9ac69e9 
* Update docker configuration section in documentation

This PR is the documentation of SeleniumHQ/selenium#10645.

* Comment out the devices declaration

[deploy site] 78dc23e
@gifflet gifflet deleted the add_docker_device_mapping branch June 3, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gifflet @diemol