[grid] Fix host option is not working issue#9981
Merged
diemol merged 2 commits intoSeleniumHQ:trunkfrom Oct 25, 2021
Merged
Conversation
this is regression bugs. refer to SeleniumHQ#5820
|
|
|
Kudos, SonarCloud Quality Gate passed! |
diemol
added a commit
that referenced
this pull request
Dec 15, 2021
#9981 fixed a regression where the Grid server was binding to all interfaces, even if a host was being configured. However, this was not ideal for environments like Docker, where the host value can be the reachable IP of the machine where the containers are running, but we cannot bind to that IP inside the container. This adds a flag where the user can decide if the server should bind to the host or not, true by default to keep the current behaviour, but it will be configured to false by default in the docker-selenium project. This is a partial fix for SeleniumHQ/docker-selenium#1453
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
this is regression bugs. refer to SeleniumHQ#5820 Co-authored-by: Diego Molina <[email protected]>
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
SeleniumHQ#9981 fixed a regression where the Grid server was binding to all interfaces, even if a host was being configured. However, this was not ideal for environments like Docker, where the host value can be the reachable IP of the machine where the containers are running, but we cannot bind to that IP inside the container. This adds a flag where the user can decide if the server should bind to the host or not, true by default to keep the current behaviour, but it will be configured to false by default in the docker-selenium project. This is a partial fix for SeleniumHQ/docker-selenium#1453
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is regression bugs.
refer to #5820
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
It is not binding host info
Types of changes
Checklist