ability to set no_vnc_port#9927
Closed
therealdjryan wants to merge 3 commits intoSeleniumHQ:trunkfrom
Closed
Conversation
diemol
added a commit
that referenced
this pull request
Mar 4, 2022
diemol
reviewed
Mar 4, 2022
Member
There was a problem hiding this comment.
@therealdjryan, my apologies, took too long for me to review this.
I am sorry, so instead of asking you for changes, I implemented the configuration flag so you can use it in the next release. Commit is linked in this PR.
Hoping to see more contributions and comments in Slack.
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Ability to set NO_VNC_PORT
Description
The vnc port is hardcoded to 7900. Allowing it to be set will enable live view for users who are not using the default port
Motivation and Context
Live view does not work for me because I am unable to set separate external and internal ports
Types of changes
Checklist
The change simply reads the system property of NO_VNC_PORT and uses the default 7900 if not set. ** @diemol, I could change this to use a command line option instead of an environment variable, but I am not all that familiar with the codebase and NO_VNC_PORT is a variable already used in docker-selenium. **