Additional Python type hints#9192
Merged
AutomatedTester merged 4 commits intoSeleniumHQ:trunkfrom Mar 1, 2021
AlbertoCentonze:trunk
Merged
Additional Python type hints#9192AutomatedTester merged 4 commits intoSeleniumHQ:trunkfrom AlbertoCentonze:trunk
AutomatedTester merged 4 commits intoSeleniumHQ:trunkfrom
AlbertoCentonze:trunk
Conversation
|
|
AutomatedTester
approved these changes
Feb 19, 2021
Member
AutomatedTester
left a comment
AutomatedTester
left a comment
There was a problem hiding this comment.
I had left those because the methods are deprecated but we can add it for now and then once Selenium 4 is released we will be deleting them
Contributor
Author
|
@AutomatedTester Where can I give a look at the new methods in Selenium 4? |
AutomatedTester
approved these changes
Mar 1, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
hudcap
reviewed
Mar 11, 2021
Contributor
hudcap
left a comment
hudcap
left a comment
There was a problem hiding this comment.
I believe all the find_elements (plural) methods should return list[WebElement] and not WebElement
Am I mistaken?
Should I open a separate PR for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I wasn't able to get the right suggestion for the code completion using pylance in vs code. That's why I started adding a few lines to improve the suggestions
Motivation and Context
I made these changes because I was working on a personal project and having those "type hints" really helped me
Types of changes
I only changed a few lines adding type hints. If this kind of changes are welcomed I'll continue to update the hints in the future when I use selenium and I need it
Checklist