[py] deprecate all but Options and Service arguments in driver instantiation.#9128
Merged
AutomatedTester merged 4 commits intoSeleniumHQ:trunkfrom Feb 4, 2021
Merged
Conversation
|
|
Member
AutomatedTester
left a comment
AutomatedTester
left a comment
There was a problem hiding this comment.
I think we can clean up chrome/webdriver.py here
| :Args: | ||
| - browser_name - Browser name used when matching capabilities. | ||
| - vendor_prefix - Company prefix to apply to vendor-specific WebDriver extension commands. | ||
| - browser_name - Deprecated: Browser name used when matching capabilities. |
Member
There was a problem hiding this comment.
Actually thinking about this we should keep browser_name and vendor_prefix due to the way inheritance is done.
Contributor
Author
There was a problem hiding this comment.
Removed browser_name and vendor_prefix from deprecation for chromium family drivers for now.
Deprecated left out keep_alive for IE & Chrome Driver and Added Deprecation warning for missing desired_capabilites for IE driver currently left is - browser_name, vendor_prefix for chromium driver family Fixes SeleniumHQ#9125
itsjwala
force-pushed
the
py_deprecated_init_params
branch
from
d454eb5 to
4f02979
Compare
Contributor
Author
should I deprecate |
AutomatedTester
approved these changes
Feb 4, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Member
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Deprecated remaining
__init__params fromchromiumandIEwebdriver classI haven't touched the
chromedriver since all the params are already deprecated if not deprecated in the parentchromiumclass.Left out
browser_name&vendor_prefixfor chromium driver familyMotivation and Context
Fixes #9125
Types of changes
Checklist