Repository navigation
[py] Implement __hash__ and explicit ScriptKey equality comparison - #18243
Merged
cgoldberg merged 3 commits intoOct 27, 2026
Merged
Conversation
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
cgoldberg
self-requested a review
October 27, 2026 19:41
cgoldberg
approved these changes
Oct 27, 2026
cgoldberg
left a comment
Member
There was a problem hiding this comment.
LGTM 👍 thanks for keeping the PRs small and focused!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ScriptKeyis used in the Python bindings as an identifier for pinned scripts (driver.pin_script(),driver.unpin()).Previously:
ScriptKeydefined__eq__without defining__hash__, which in Python 3 implicitly sets__hash__ = None. Attempting to use aScriptKeyin a dictionary or set raisedTypeError: unhashable type: 'ScriptKey'.__eq__comparedself._id == otherdirectly without checking whetherotheris an instance ofScriptKeyor a raw ID, relying on reflected equality forScriptKey == ScriptKey.This PR:
__hash__returninghash(self._id)soScriptKeyinstances can be hashed and stored in sets or mappings.self._id == other._idwhenotheris an instance ofScriptKey, while preserving raw ID comparisons.py/test/unit/selenium/webdriver/remote/script_key_tests.py.Motivation and Context
Enables using \ScriptKey\ objects as keys in hash mappings/sets and resolves Ruff warning \PLW1641.
Types of changes
Checklist