Skip to content

[dotnet] Actualize readme how to run tests #17272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvborisenko merged 1 commit into from
Mar 29, 2026
+3 −3
Merged

[dotnet] Actualize readme how to run tests #17272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,19 +491,19 @@ echo '<X.Y.Z>' > rb/.ruby-version
Run all tests with:

```shell
bazel test //dotnet/test/common:AllTests
bazel test //dotnet/test/common
Copy link
Copy Markdown
Contributor

@qodo-code-review qodo-code-review bot Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Wrong bazel all-tests target 🐞 Bug ✓ Correctness

bazel test //dotnet/test/common runs the underlying :common compiled test binary and bypasses
the generated wrapper tests that pass --params=ActiveDriverConfig=... plus pinned
DriverService/Browser locations. The run therefore falls back to appconfig defaults (e.g.,
ActiveDriverConfig: Chrome with empty locations) and does not use the pinned browser/driver
runfiles that the Bazel suite is designed to use.
Agent Prompt 
### Issue description
README’s “Run all tests” command uses `bazel test //dotnet/test/common`, which executes the base compiled test binary target (`:common`) and bypasses the generated wrapper targets that inject the required browser/pinned-driver parameters.

### Issue Context
The Bazel macro `dotnet_nunit_test_suite` compiles a single binary (`name = "common"`) and then generates wrapper test targets per test file and browser that pass `--params=ActiveDriverConfig=...` and pinned `DriverServiceLocation`/`BrowserLocation` via `$(location ...)`. Running the base target does not apply those wrapper args and instead falls back to `appconfig.json` defaults.

### Fix Focus Areas
- README.md[491-507]

### Suggested change
Update the “Run all tests with:” command to a target pattern that runs the generated wrapper tests (e.g. `bazel test //dotnet/test/common:all`), and/or document the correct wrapper suite(s) to use for running the full set under the intended default browser.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

```

You can run specific tests by specifying the class name:

```shell
bazel test //dotnet/test/common:ElementFindingTest
bazel test //dotnet/test/common:ElementFindingTests
```

If the module supports multiple browsers:

```shell
bazel test //dotnet/test/common:ElementFindingTest-edge
bazel test //dotnet/test/common:ElementFindingTests-edge
```

</details>
Expand Down
Loading