[dotnet] Actualize readme how to run tests#17272
[dotnet] Actualize readme how to run tests#17272nvborisenko merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
Review Summary by QodoUpdate dotnet README test command examples
WalkthroughsDescription• Update Bazel test target names to match actual test class names • Correct AllTests to remove target suffix • Fix ElementFindingTest to ElementFindingTests in examples • Update multi-browser test target naming convention File Changes1. README.md
|
Code Review by Qodo
1. Wrong Bazel all-tests target
|
|
|
||
| ```shell | ||
| bazel test //dotnet/test/common:AllTests | ||
| bazel test //dotnet/test/common |
There was a problem hiding this comment.
1. Wrong bazel all-tests target 🐞 Bug ✓ Correctness
bazel test //dotnet/test/common runs the underlying :common compiled test binary and bypasses the generated wrapper tests that pass --params=ActiveDriverConfig=... plus pinned DriverService/Browser locations. The run therefore falls back to appconfig defaults (e.g., ActiveDriverConfig: Chrome with empty locations) and does not use the pinned browser/driver runfiles that the Bazel suite is designed to use.
Agent Prompt
### Issue description
README’s “Run all tests” command uses `bazel test //dotnet/test/common`, which executes the base compiled test binary target (`:common`) and bypasses the generated wrapper targets that inject the required browser/pinned-driver parameters.
### Issue Context
The Bazel macro `dotnet_nunit_test_suite` compiles a single binary (`name = "common"`) and then generates wrapper test targets per test file and browser that pass `--params=ActiveDriverConfig=...` and pinned `DriverServiceLocation`/`BrowserLocation` via `$(location ...)`. Running the base target does not apply those wrapper args and instead falls back to `appconfig.json` defaults.
### Fix Focus Areas
- README.md[491-507]
### Suggested change
Update the “Run all tests with:” command to a target pattern that runs the generated wrapper tests (e.g. `bazel test //dotnet/test/common:all`), and/or document the correct wrapper suite(s) to use for running the full set under the intended default browser.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This pull request makes a minor update to the
README.mdfile, adjusting the Bazel test target names to match the correct test class names in the documentation.🔄 Types of changes