Skip to content

[dotnet] Actualize readme how to run tests#17272

Merged
nvborisenko merged 1 commit intoSeleniumHQ:trunkfrom
nvborisenko:dotnet-readme
Mar 29, 2026
Merged

[dotnet] Actualize readme how to run tests#17272
nvborisenko merged 1 commit intoSeleniumHQ:trunkfrom
nvborisenko:dotnet-readme

Conversation

@nvborisenko
Copy link
Copy Markdown
Member

This pull request makes a minor update to the README.md file, adjusting the Bazel test target names to match the correct test class names in the documentation.

🔄 Types of changes

  • Cleanup (formatting, renaming)

@qodo-code-review
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Update dotnet README test command examples

📝 Documentation

Grey Divider

Walkthroughs

Description
• Update Bazel test target names to match actual test class names
• Correct AllTests to remove target suffix
• Fix ElementFindingTest to ElementFindingTests in examples
• Update multi-browser test target naming convention

Grey Divider

File Changes

1. README.md 📝 Documentation +3/-3

Correct dotnet test command examples in README

• Changed bazel test //dotnet/test/common:AllTests to bazel test //dotnet/test/common
• Updated ElementFindingTest to ElementFindingTests in single browser test example
• Updated ElementFindingTest-edge to ElementFindingTests-edge in multi-browser test example
• Corrected test target naming to match actual test class names

README.md


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review bot commented Mar 29, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Action required

1. Wrong Bazel all-tests target 🐞 Bug ✓ Correctness
Description
bazel test //dotnet/test/common runs the underlying :common compiled test binary and bypasses
the generated wrapper tests that pass --params=ActiveDriverConfig=... plus pinned
DriverService/Browser locations. The run therefore falls back to appconfig defaults (e.g.,
ActiveDriverConfig: Chrome with empty locations) and does not use the pinned browser/driver
runfiles that the Bazel suite is designed to use.
Code

README.md[494]

+bazel test //dotnet/test/common
Evidence
//dotnet/test/common is a shorthand label for //dotnet/test/common:common, which is the base
compiled test binary. The Bazel macro intentionally generates per-test (and per-browser) wrapper
targets that provide --params=ActiveDriverConfig=... and pinned
DriverServiceLocation/BrowserLocation args; without those args, the test runtime falls back to
values from appconfig.json (defaulting to Chrome and empty locations), and the driver/browser
paths are not applied.

README.md[484-507]
dotnet/test/common/BUILD.bazel[25-50]
dotnet/private/dotnet_nunit_test_suite.bzl[180-216]
dotnet/private/dotnet_nunit_test_suite.bzl[10-69]
dotnet/test/common/Environment/EnvironmentManager.cs[59-66]
dotnet/test/common/appconfig.json[1-5]
dotnet/test/common/Environment/DriverFactory.cs[90-95]
dotnet/test/common/Environment/DriverFactory.cs[149-153]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
README’s “Run all tests” command uses `bazel test //dotnet/test/common`, which executes the base compiled test binary target (`:common`) and bypasses the generated wrapper targets that inject the required browser/pinned-driver parameters.

### Issue Context
The Bazel macro `dotnet_nunit_test_suite` compiles a single binary (`name = "common"`) and then generates wrapper test targets per test file and browser that pass `--params=ActiveDriverConfig=...` and pinned `DriverServiceLocation`/`BrowserLocation` via `$(location ...)`. Running the base target does not apply those wrapper args and instead falls back to `appconfig.json` defaults.

### Fix Focus Areas
- README.md[491-507]

### Suggested change
Update the “Run all tests with:” command to a target pattern that runs the generated wrapper tests (e.g. `bazel test //dotnet/test/common:all`), and/or document the correct wrapper suite(s) to use for running the full set under the intended default browser.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@nvborisenko nvborisenko merged commit d26b709 into SeleniumHQ:trunk Mar 29, 2026
7 of 8 checks passed
@nvborisenko nvborisenko deleted the dotnet-readme branch March 29, 2026 21:41

```shell
bazel test //dotnet/test/common:AllTests
bazel test //dotnet/test/common
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Wrong bazel all-tests target 🐞 Bug ✓ Correctness

bazel test //dotnet/test/common runs the underlying :common compiled test binary and bypasses
the generated wrapper tests that pass --params=ActiveDriverConfig=... plus pinned
DriverService/Browser locations. The run therefore falls back to appconfig defaults (e.g.,
ActiveDriverConfig: Chrome with empty locations) and does not use the pinned browser/driver
runfiles that the Bazel suite is designed to use.
Agent Prompt
### Issue description
README’s “Run all tests” command uses `bazel test //dotnet/test/common`, which executes the base compiled test binary target (`:common`) and bypasses the generated wrapper targets that inject the required browser/pinned-driver parameters.

### Issue Context
The Bazel macro `dotnet_nunit_test_suite` compiles a single binary (`name = "common"`) and then generates wrapper test targets per test file and browser that pass `--params=ActiveDriverConfig=...` and pinned `DriverServiceLocation`/`BrowserLocation` via `$(location ...)`. Running the base target does not apply those wrapper args and instead falls back to `appconfig.json` defaults.

### Fix Focus Areas
- README.md[491-507]

### Suggested change
Update the “Run all tests with:” command to a target pattern that runs the generated wrapper tests (e.g. `bazel test //dotnet/test/common:all`), and/or document the correct wrapper suite(s) to use for running the full set under the intended default browser.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant