• Fixes platform/architecture detection for Selenium Manager
• Normalizes amd64/AMD64 architecture to x86_64
• Handles BSD platform names with version numbers
• Restricts Windows to x86_64 architecture only
• Adds comprehensive unit tests for platform detection

Improve platform and architecture detection logic

• Changed Windows platform to require x86_64 architecture instead of "any"
• Added normalization of amd64/AMD64 to x86_64 for consistent handling
• Added logic to strip version numbers from BSD platform names (freebsd15 → freebsd)
• Improved FreeBSD warning message with actionable instructions about brandelf and linux64.ko
• Refactored architecture detection to use lowercase normalization

py/selenium/webdriver/common/selenium_manager.py

Add tests for platform and architecture detection

• Added import for logging module
• Added test_uses_windows_arm64 to verify ARM64 raises exception on Windows
• Added test_uses_freebsd to verify FreeBSD platform detection with amd64 normalization
• Verified warning message is logged for FreeBSD compatibility
• Cleaned up whitespace in existing tests

py/test/unit/selenium/webdriver/common/selenium_manager_tests.py

Description

test_uses_windows only monkeypatches sys.platform to win32; after this PR,
SeleniumManager._get_binary reads platform.machine() for Windows and only allows x86_64, so the test
can fail on ARM64/non-x86_64 runners by raising WebDriverException instead of returning the expected
path.

Code

py/test/unit/selenium/webdriver/common/selenium_manager_tests.py[R53-57]

def test_uses_windows(monkeypatch):
    monkeypatch.setattr(sys, "platform", "win32")
    binary = SeleniumManager()._get_binary()
-
    project_root = Path(selenium.__file__).parent.parent
    assert binary == project_root.joinpath("selenium/webdriver/common/windows/selenium-manager.exe")

Evidence

_get_binary now derives arch from platform.machine().lower() for non-darwin platforms and only maps
Windows to the binary for (win32, x86_64). test_uses_windows sets sys.platform to win32 but does not
control platform.machine(), making the test outcome depend on the host CPU architecture (e.g., ARM64
runners will raise the unsupported-platform exception).

py/selenium/webdriver/common/selenium_manager.py[90-117]
py/test/unit/selenium/webdriver/common/selenium_manager_tests.py[53-58]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`test_uses_windows` becomes architecture-dependent because `_get_binary()` now calls `platform.machine()` on Windows and only supports `x86_64`, but the test does not monkeypatch `platform.machine()`.

### Issue Context
On ARM64/non-x86_64 CI runners, `platform.machine()` will not be `amd64/AMD64/x86_64`, causing `_get_binary()` to raise and the test to fail.

### Fix Focus Areas
- py/test/unit/selenium/webdriver/common/selenium_manager_tests.py[53-58]

### Suggested change
In `test_uses_windows`, add `monkeypatch.setattr("platform.machine", lambda: "AMD64")` (or `"x86_64"`) before calling `_get_binary()` so the test is deterministic across CI architectures.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools