Skip to content

[dotnet] [build] Move build targets from cdp to DevTools #17267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvborisenko merged 1 commit into from
Mar 29, 2026
Merged

[dotnet] [build] Move build targets from cdp to DevTools #17267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet/defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ load("//dotnet/private:paket_deps.bzl", _paket_deps = "paket_deps")
def devtools_version_targets():
targets = []
for devtools_version in SUPPORTED_DEVTOOLS_VERSIONS:
targets.append("//dotnet/src/webdriver/cdp:generate-{}".format(devtools_version))
targets.append("//dotnet/src/webdriver/DevTools:generate-{}".format(devtools_version))
return targets

csharp_binary = _csharp_binary
Expand Down
12 changes: 6 additions & 6 deletions dotnet/src/webdriver/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ csharp_library(
":resource-utilities",
] + glob([
"**/*.cs",
]) + devtools_version_targets(),
]) + ["//dotnet/src/webdriver/DevTools:srcs"] + devtools_version_targets(),
out = "WebDriver",
internals_visible_to = [
"WebDriver.Common.Tests",
Expand Down Expand Up @@ -79,7 +79,7 @@ csharp_library(
":resource-utilities",
] + glob([
"**/*.cs",
]) + devtools_version_targets(),
]) + ["//dotnet/src/webdriver/DevTools:srcs"] + devtools_version_targets(),
out = "WebDriver",
internals_visible_to = [
"WebDriver.Common.Tests",
Expand Down Expand Up @@ -113,7 +113,7 @@ csharp_library(
":resource-utilities",
] + glob([
"**/*.cs",
]) + devtools_version_targets(),
]) + ["//dotnet/src/webdriver/DevTools:srcs"] + devtools_version_targets(),
out = "WebDriver",
defines = [
"NET8_0_OR_GREATER",
Expand All @@ -140,7 +140,7 @@ csharp_library(
":resource-utilities",
] + glob([
"**/*.cs",
]) + devtools_version_targets(),
]) + ["//dotnet/src/webdriver/DevTools:srcs"] + devtools_version_targets(),
out = "WebDriver.StrongNamed",
keyfile = "//dotnet:Selenium.snk",
langversion = "14.0",
Expand Down Expand Up @@ -171,7 +171,7 @@ csharp_library(
":resource-utilities",
] + glob([
"**/*.cs",
]) + devtools_version_targets(),
]) + ["//dotnet/src/webdriver/DevTools:srcs"] + devtools_version_targets(),
out = "WebDriver.StrongNamed",
keyfile = "//dotnet:Selenium.snk",
langversion = "14.0",
Expand Down Expand Up @@ -203,7 +203,7 @@ csharp_library(
":resource-utilities",
] + glob([
"**/*.cs",
]) + devtools_version_targets(),
]) + ["//dotnet/src/webdriver/DevTools:srcs"] + devtools_version_targets(),
out = "WebDriver.StrongNamed",
defines = [
"NET8_0_OR_GREATER",
Expand Down
6 changes: 6 additions & 0 deletions dotnet/src/webdriver/cdp/BUILD.bazel → dotnet/src/webdriver/DevTools/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
load("//dotnet:defs.bzl", "generate_devtools")
load("//dotnet:selenium-dotnet-version.bzl", "SUPPORTED_DEVTOOLS_VERSIONS")

filegroup(
name = "srcs",
srcs = glob(["**/*.cs"]),
visibility = ["//dotnet/src/webdriver:__pkg__"],
)

[
generate_devtools(
name = "generate-{}".format(devtools_version),
Expand Down
8 changes: 4 additions & 4 deletions dotnet/src/webdriver/cdp/README.md → dotnet/src/webdriver/DevTools/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ add an entry for version `<N>` to the `SupportedDevToolsVersions` dictionary ini
add the following block (substituting the proper value for `<N>`):

```bash
if not exist "%1..\..\..\bazel-bin\dotnet\src\webdriver\cdp\v<N>\DevToolsSessionDomains.cs" (
if not exist "%1..\..\..\bazel-bin\dotnet\src\webdriver\DevTools\v<N>\DevToolsSessionDomains.cs" (
echo Generating CDP code for version <N>
pushd "%1..\..\.."
bazel build //dotnet/src/webdriver/cdp:generate-v<N>
bazel build //dotnet/src/webdriver/DevTools:generate-v<N>
popd
)
```
Expand All @@ -30,10 +30,10 @@ if not exist "%1..\..\..\bazel-bin\dotnet\src\webdriver\cdp\v<N>\DevToolsSessio
add the following block (substituting the proper value for `<N>`):

```bash
if [[ ! -f "$1../../../bazel-bin/dotnet/src/webdriver/cdp/v<N>/DevToolsSessionDomains.cs" ]]
if [[ ! -f "$1../../../bazel-bin/dotnet/src/webdriver/DevTools/v<N>/DevToolsSessionDomains.cs" ]]
then
echo "Generating CDP code for version <N>"
bazel build //dotnet/src/webdriver/cdp:generate-v<N>
bazel build //dotnet/src/webdriver/DevTools:generate-v<N>
fi
```

Expand Down
4 changes: 2 additions & 2 deletions dotnet/src/webdriver/Selenium.WebDriver.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@
</Target>

<Target Name="GenerateCdp" BeforeTargets="CoreCompile">
<Exec Command="bazel build //dotnet/src/webdriver/cdp/..." WorkingDirectory="../../.." />
<Exec Command="bazel build //dotnet/src/webdriver/DevTools/..." WorkingDirectory="../../.." />

<ItemGroup>
<Compile Include="..\..\..\bazel-bin\dotnet\src\webdriver\cdp\**\*.cs" LinkBase="DevTools\generated" />
<Compile Include="..\..\..\bazel-bin\dotnet\src\webdriver\DevTools\**\*.cs" LinkBase="DevTools\generated" />
</ItemGroup>
</Target>

Expand Down
Loading