Skip to content

[dotnet] [build] Move build targets from cdp to DevTools#17267

Merged
nvborisenko merged 1 commit intoSeleniumHQ:trunkfrom
nvborisenko:dotnet-build-cdp-devtools
Mar 29, 2026
Merged

[dotnet] [build] Move build targets from cdp to DevTools#17267
nvborisenko merged 1 commit intoSeleniumHQ:trunkfrom
nvborisenko:dotnet-build-cdp-devtools

Conversation

@nvborisenko
Copy link
Copy Markdown
Member

@nvborisenko nvborisenko commented Mar 28, 2026

cdp -> existing DevTools

💥 What does this PR do?

This pull request reorganizes and renames the CDP (Chrome DevTools Protocol) code generation logic in the .NET WebDriver project. The main change is moving all CDP-related files and build targets from the cdp directory to a new DevTools directory, updating all relevant references and build scripts accordingly. This improves clarity and maintainability by using a more descriptive and consistent directory and target naming scheme.

🔄 Types of changes

  • Cleanup (formatting, renaming)

@selenium-ci selenium-ci added C-dotnet .NET Bindings B-build Includes scripting, bazel and CI integrations labels Mar 28, 2026
@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review bot commented Mar 28, 2026

Review Summary by Qodo

Reorganize .NET CDP build targets to DevTools directory

✨ Enhancement

Grey Divider

Walkthroughs

Description 
• Reorganize CDP build targets from cdp to DevTools directory
• Update all build configuration references to new directory structure
• Add srcs filegroup for DevTools generated source files
• Update documentation and build scripts with new paths

Grey Divider

File Changes

1. dotnet/defs.bzl ⚙️ Configuration changes +1/-1

Update devtools version targets path

• Update devtools_version_targets() function to reference //dotnet/src/webdriver/DevTools
 instead of //dotnet/src/webdriver/cdp

dotnet/defs.bzl

2. dotnet/src/webdriver/BUILD.bazel ⚙️ Configuration changes +6/-6

Add DevTools srcs to library targets

• Add ["//dotnet/src/webdriver/DevTools:srcs"] to source dependencies in all six csharp_library
 targets
• Update path references from cdp to DevTools across net462, netstandard2.0, net8.0, and
 strongnamed variants

dotnet/src/webdriver/BUILD.bazel

3. dotnet/src/webdriver/DevTools/BUILD.bazel ✨ Enhancement +6/-0

Add srcs filegroup for DevTools

• Add new filegroup named srcs that globs all C# files in DevTools directory
• Set visibility to //dotnet/src/webdriver:__pkg__ for cross-package access

dotnet/src/webdriver/DevTools/BUILD.bazel

View more (2)
4. dotnet/src/webdriver/DevTools/README.md 📝 Documentation +4/-4

Update documentation paths and build commands

• Update Windows batch script path from cdp\v<N> to DevTools\v<N>
• Update Windows batch bazel build command from //dotnet/src/webdriver/cdp:generate-v<N> to
 //dotnet/src/webdriver/DevTools:generate-v<N>
• Update Unix shell script path from cdp/v<N> to DevTools/v<N>
• Update Unix shell bazel build command from //dotnet/src/webdriver/cdp:generate-v<N> to
 //dotnet/src/webdriver/DevTools:generate-v<N>

dotnet/src/webdriver/DevTools/README.md

5. dotnet/src/webdriver/Selenium.WebDriver.csproj ⚙️ Configuration changes +2/-2

Update project file build paths

• Update GenerateCdp target bazel build command from //dotnet/src/webdriver/cdp/... to
 //dotnet/src/webdriver/DevTools/...
• Update compile include path from bazel-bin\dotnet\src\webdriver\cdp\**\*.cs to
 bazel-bin\dotnet\src\webdriver\DevTools\**\*.cs

dotnet/src/webdriver/Selenium.WebDriver.csproj

Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review bot commented Mar 28, 2026 •
edited
Loading

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@nvborisenko nvborisenko merged commit 36fc8f9 into SeleniumHQ:trunk Mar 29, 2026
21 of 22 checks passed
@nvborisenko nvborisenko deleted the dotnet-build-cdp-devtools branch March 29, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

B-build Includes scripting, bazel and CI integrations C-dotnet .NET Bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nvborisenko @selenium-ci