Skip to content

[build] Skip macOS-only archive rules on unsupported platforms #16985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
titusfortner merged 4 commits into from
Jan 24, 2026
Merged

[build] Skip macOS-only archive rules on unsupported platforms #16985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed379d9
skip macOS-only archive rules on unsupported platforms
titusfortner Jan 23, 2026
0cb1a49
fixup! skip macOS-only archive rules on unsupported platforms
titusfortner Jan 23, 2026
2214de1
fixup! skip macOS-only archive rules on unsupported platforms
titusfortner Jan 24, 2026
3e48adb
fixup! skip macOS-only archive rules on unsupported platforms
titusfortner Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions common/private/dmg_archive.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
def _dmg_archive_impl(repository_ctx):
repository_ctx.file("BUILD.bazel", repository_ctx.attr.build_file_content)

if not repository_ctx.which("hdiutil"):
# hdiutil is macOS-only; skip download on other platforms
return

url = repository_ctx.attr.url
(ignored, ignored, dmg_name) = url.rpartition("/")
dmg_name = dmg_name.replace("%20", "_")
Expand Down Expand Up @@ -27,11 +33,6 @@ def _dmg_archive_impl(repository_ctx):
output = repository_ctx.attr.output,
)

repository_ctx.file(
"BUILD.bazel",
repository_ctx.attr.build_file_content,
)

dmg_archive = repository_rule(
_dmg_archive_impl,
attrs = {
Expand Down
8 changes: 6 additions & 2 deletions common/private/pkg_archive.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
def _pkg_archive_impl(repository_ctx):
repository_ctx.file("BUILD.bazel", repository_ctx.attr.build_file_content)

if not repository_ctx.which("pkgutil"):
# pkgutil is macOS-only; skip download on other platforms
return

url = repository_ctx.attr.url
(ignored, ignored, pkg_name) = url.rpartition("/")
idx = pkg_name.find("?")
Expand Down Expand Up @@ -27,8 +33,6 @@ def _pkg_archive_impl(repository_ctx):
for (key, value) in repository_ctx.attr.move.items():
repository_ctx.execute(["mv", pkg_name + "/" + key, value])

repository_ctx.file("BUILD.bazel", repository_ctx.attr.build_file_content)

pkg_archive = repository_rule(
_pkg_archive_impl,
attrs = {
Expand Down
32 changes: 16 additions & 16 deletions common/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,15 @@ exports_files(["Firefox.app"])

js_library(
name = "firefox-js",
data = glob(["Firefox.app/**/*"]),
data = glob(["Firefox.app/**/*"], allow_empty = True),
)
""",
)

http_archive(
name = "linux_beta_firefox",
url = "https://ftp.mozilla.org/pub/firefox/releases/148.0b5/linux-x86_64/en-US/firefox-148.0b5.tar.xz",
sha256 = "1fdfc9f8745312ff02cca569dee7950e26733613605ffc11b630585a7fd638cc",
url = "https://ftp.mozilla.org/pub/firefox/releases/148.0b6/linux-x86_64/en-US/firefox-148.0b6.tar.xz",
sha256 = "f49b2bca17d36bd2fdd277d81a4b5f5e3cf4f034fb18622f658fb5090d4de62b",
build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])
Expand All @@ -72,8 +72,8 @@ js_library(

dmg_archive(
name = "mac_beta_firefox",
url = "https://ftp.mozilla.org/pub/firefox/releases/148.0b5/mac/en-US/Firefox%20148.0b5.dmg",
sha256 = "d2527e345b78acba3ded68a09031f957e3ff1173a8c872a409074d1dc4e034e1",
url = "https://ftp.mozilla.org/pub/firefox/releases/148.0b6/mac/en-US/Firefox%20148.0b6.dmg",
sha256 = "7f79d044c1b0eb8894e28c0043d3152a102a6f1121a53ff8f5f80478ab6d94fe",
build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])
Expand All @@ -82,7 +82,7 @@ exports_files(["Firefox.app"])

js_library(
name = "firefox-js",
data = glob(["Firefox.app/**/*"]),
data = glob(["Firefox.app/**/*"], allow_empty = True),
)
""",
)
Expand Down Expand Up @@ -123,10 +123,10 @@ js_library(

pkg_archive(
name = "mac_edge",
url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/4f2967c0-d097-4ac0-92b7-15af707ac2ac/MicrosoftEdge-144.0.3719.82.pkg",
sha256 = "b09345f33d65c3b4a81ae3001fc3d9bc529b11b39c0e2e0f6571c086b28208c7",
url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/4decc3c7-748d-42a6-be1d-9f976831cf72/MicrosoftEdge-144.0.3719.92.pkg",
sha256 = "a28f7d0d27e163fdd23755dadb5870d6a1c87183f2185d25e618365afd1e3940",
move = {
"MicrosoftEdge-144.0.3719.82.pkg/Payload/Microsoft Edge.app": "Edge.app",
"MicrosoftEdge-144.0.3719.92.pkg/Payload/Microsoft Edge.app": "Edge.app",
},
build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
Expand All @@ -136,15 +136,15 @@ exports_files(["Edge.app"])

js_library(
name = "edge-js",
data = glob(["Edge.app/**/*"]),
data = glob(["Edge.app/**/*"], allow_empty = True),
)
""",
)

deb_archive(
name = "linux_edge",
url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_144.0.3719.82-1_amd64.deb",
sha256 = "5bbc13fb568d17b66e8583d0d9502f56027ee465aca291270ccf4585da710488",
url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_144.0.3719.92-1_amd64.deb",
sha256 = "7e2d6f408734ebd1d2eedfe917e6c2fd005bc996e942f820532b7da63299501a",
build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])
Expand All @@ -165,8 +165,8 @@ js_library(

http_archive(
name = "linux_edgedriver",
url = "https://msedgedriver.microsoft.com/144.0.3719.82/edgedriver_linux64.zip",
sha256 = "2406cd14224e77e709ed4b704e4510980577e53a25956fec4a558cb8a4b43671",
url = "https://msedgedriver.microsoft.com/144.0.3719.92/edgedriver_linux64.zip",
sha256 = "4f1bcca134b2c246ec72250ff50257a8cdca1c575fbd64e595bcd1c558788728",
build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])
Expand All @@ -182,8 +182,8 @@ js_library(

http_archive(
name = "mac_edgedriver",
url = "https://msedgedriver.microsoft.com/144.0.3719.82/edgedriver_mac64_m1.zip",
sha256 = "76ab16cdff3ceea7e30add9f183948cda068dfd3b05d3a6e26e667ffcef54c7b",
url = "https://msedgedriver.microsoft.com/144.0.3719.92/edgedriver_mac64_m1.zip",
sha256 = "ddc62f83e3462a5d69b627b686d6c03e77db8ad7e6cc5d3f8dfbc431a6438d65",
build_file_content = """
load("@aspect_rules_js//js:defs.bzl", "js_library")
package(default_visibility = ["//visibility:public"])
Expand Down
4 changes: 2 additions & 2 deletions scripts/pinned_browsers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ def mac_edge_browser_content(browser_url, browser_hash, browser_version):

js_library(
name = "edge-js",
data = glob(["Edge.app/**/*"]),
data = glob(["Edge.app/**/*"], allow_empty = True),
)
\"\"\",
)
Expand Down Expand Up @@ -509,7 +509,7 @@ def print_firefox(version, workspace_name, sha_linux, sha_mac):

js_library(
name = "firefox-js",
data = glob(["Firefox.app/**/*"]),
data = glob(["Firefox.app/**/*"], allow_empty = True),
)
\"\"\",
)
Expand Down
Loading