Skip to content

[py] make bazel test target names consistent with other languages #16969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
titusfortner merged 4 commits into from
Jan 22, 2026
Merged

[py] make bazel test target names consistent with other languages #16969

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43f14cc
rearrange python test target naming
titusfortner Jan 21, 2026
5616e96
[py] Keep test/ prefix to avoid module shadowing on Windows
titusfortner Jan 22, 2026
0ce7f1c
[py] Convert _tests suffix to _test in test target names
titusfortner Jan 22, 2026
9e14de7
[py] Keep _tests suffix in test target names
titusfortner Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion py/private/suite.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@ load("//py/private:pytest.bzl", "pytest_test")
def _is_test(file):
return file.startswith("test_") or file.endswith("_tests.py")

def _suite_suffix(name):
return name[len("test-"):] if name.startswith("test-") else name

def _strip_test_prefixes(path):
if path.endswith(".py"):
path = path[:-len(".py")]
filename = path.rsplit("/", 1)[-1]
if filename.startswith("test_"):
path = path[:-len(filename)] + filename[len("test_"):]
return path

def py_test_suite(name, srcs, size = None, deps = None, python_version = None, imports = None, visibility = None, **kwargs):
library_name = "%s-test-lib" % name

Expand All @@ -19,7 +30,7 @@ def py_test_suite(name, srcs, size = None, deps = None, python_version = None, i
tests = []
for src in srcs:
if _is_test(src):
test_name = "%s-%s" % (name, src)
test_name = "%s-%s" % (_strip_test_prefixes(src), _suite_suffix(name))

tests.append(test_name)

Expand Down