Skip to content

[build] Fix Bazel NuGet push implementation #16950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
titusfortner merged 2 commits into from
Jan 19, 2026
Merged

[build] Fix Bazel NuGet push implementation #16950

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16d3eee
[build] fix bazel nuget push implementation
titusfortner Jan 19, 2026
bdf25a7
update with feedback
titusfortner Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 34 additions & 8 deletions dotnet/private/nuget_push.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ def _nuget_push_impl(ctx):
else:
script = _create_unix_script(ctx, dotnet, nupkg_files)

runfiles = ctx.runfiles(files = nupkg_files).merge(toolchain.runtime.default_runfiles)
runfiles = ctx.runfiles(files = nupkg_files + [dotnet])
runfiles = runfiles.merge(toolchain.runtime.default_runfiles)

return [
DefaultInfo(
Expand All @@ -22,20 +23,45 @@ def _nuget_push_impl(ctx):
),
]

def _to_runfiles_path(short_path):
"""Convert a short_path to a runfiles path.

External repos in bzlmod have paths like ../repo_name/path,
which in runfiles becomes repo_name/path.
Main repo paths need _main/ prefix.
"""
if short_path.startswith("../"):
return short_path[3:]
return "_main/" + short_path

def _create_unix_script(ctx, dotnet, nupkg_files):
"""Create bash script for Unix/macOS/Linux."""
push_commands = []
for nupkg in nupkg_files:
nupkg_runfiles_path = _to_runfiles_path(nupkg.short_path)
push_commands.append(
'"$DOTNET" nuget push "%s" --api-key "$NUGET_API_KEY" --source "$NUGET_SOURCE"' % nupkg.short_path,
'"$DOTNET" nuget push "$RUNFILES_DIR/{nupkg}" --api-key "$NUGET_API_KEY" --source "$NUGET_SOURCE" --skip-duplicate'.format(nupkg = nupkg_runfiles_path),
)

dotnet_runfiles_path = _to_runfiles_path(dotnet.short_path)

script_content = """#!/usr/bin/env bash
set -euo pipefail
DOTNET="$(cd "$(dirname "$0")" && pwd)/{dotnet}"

# Locate runfiles directory
if [[ -d "$0.runfiles/_main" ]]; then
RUNFILES_DIR="$0.runfiles"
elif [[ -n "${{RUNFILES_DIR:-}}" ]]; then
RUNFILES_DIR="$RUNFILES_DIR"
else
echo "ERROR: Could not locate runfiles directory" >&2
exit 1
fi

DOTNET="$RUNFILES_DIR/{dotnet}"
{push_commands}
""".format(
dotnet = dotnet.short_path,
dotnet = dotnet_runfiles_path,
push_commands = "\n".join(push_commands),
)

Expand All @@ -51,19 +77,19 @@ def _create_windows_script(ctx, dotnet, nupkg_files):
"""Create batch script for Windows."""
push_commands = []
for nupkg in nupkg_files:
nupkg_path = nupkg.short_path.replace("/", "\\")
nupkg_runfiles_path = _to_runfiles_path(nupkg.short_path).replace("/", "\\")
push_commands.append(
'"%%DOTNET%%" nuget push "%s" --api-key "%%NUGET_API_KEY%%" --source "%%NUGET_SOURCE%%"' % nupkg_path,
'"%%DOTNET%%" nuget push "%%~dp0%s" --api-key "%%NUGET_API_KEY%%" --source "%%NUGET_SOURCE%%" --skip-duplicate' % nupkg_runfiles_path,
)
push_commands.append("if %%ERRORLEVEL%% neq 0 exit /b %%ERRORLEVEL%%")

dotnet_path = dotnet.short_path.replace("/", "\\")
dotnet_runfiles_path = _to_runfiles_path(dotnet.short_path).replace("/", "\\")

script_content = """@echo off
set DOTNET=%~dp0{dotnet_path}
{push_commands}
""".format(
dotnet_path = dotnet_path,
dotnet_path = dotnet_runfiles_path,
push_commands = "\n".join(push_commands),
)

Expand Down