Skip to content

[grid] Update handling SessionId from json #16683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VietND96 merged 1 commit into from
Dec 5, 2025
Merged

[grid] Update handling SessionId from json #16683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion java/src/org/openqa/selenium/remote/SessionId.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.openqa.selenium.remote;

import java.io.Serializable;
import java.util.Map;
import java.util.UUID;
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;
Expand Down Expand Up @@ -52,7 +53,7 @@ public boolean equals(@Nullable Object obj) {
return obj instanceof SessionId && opaqueKey.equals(((SessionId) obj).opaqueKey);
}

private Object toJson() {
private String toJson() {
return opaqueKey;
}

Expand All @@ -61,6 +62,13 @@ private static SessionId fromJson(Object raw) {
return new SessionId(String.valueOf(raw));
}

if (raw instanceof Map) {
Map<?, ?> map = (Map<?, ?>) raw;
if (map.get("value") instanceof String) {
return new SessionId(String.valueOf(map.get("value")));
}
}

throw new JsonException("Unable to coerce session id from " + raw);
}
}
Loading