PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

if value is not None and self.altitude is None:
    raise ValueError("altitude_accuracy cannot be set without altitude")

@altitude.setter
def altitude(self, value):
    self._altitude = value

PR Code Suggestions ✨

Explore these optional code suggestions:

 @altitude_accuracy.setter
 def altitude_accuracy(self, value):
-    if value is not None and self.altitude is None:
+    if value is not None and self._altitude is None:
         raise ValueError("altitude_accuracy cannot be set without altitude")
     if value is not None and value < 0.0:
         raise ValueError("Altitude accuracy must be >= 0.0")
     self._altitude_accuracy = value

@navin772 The co-ordinates gets validated only while creating an instance. But one can change the attributes even after creating instance.. e.g.

coords = GeolocationCoordinates(45.5, -122.4194, accuracy=10.0)
coords.latitude = "45.5"  # bad value. this will not be caught in the current code on the trunk and this does't go through constructor.

So it's Safe and standard practice to have it inside a private attribute and provide access to the user via Getter and Setter interface. Definitely it's not a good practice to have all those attributes validated in constructor. By having separate set of getters/setters the code is more clean and readable.

setters are meant for validating the values before attributes are being set. In this case we are actually validating the values of co-ordinates before setting it. So obvious choice is to use setters, which I don't feel it as overkill. why would someone use setters if it is not for validation? Let me know your thoughts on this. Thanks!

But one can change the attributes even after creating instance

This seems like a valid argument, what do you think @cgoldberg?

If we care about enforcing validation of coordinates after the class is instantiated, this PR is good. I don't have a strong preference, but would be fine merging this.

@cgoldberg done! Removed capitalisation of all attributes in error messages.