Skip to content

[java] deprecate FtpProxy#15907

Merged
Delta456 merged 1 commit intoSeleniumHQ:trunkfrom
Delta456:java_ftp_proxy_deprecate
Jun 18, 2025
Merged

[java] deprecate FtpProxy#15907
Delta456 merged 1 commit intoSeleniumHQ:trunkfrom
Delta456:java_ftp_proxy_deprecate

Conversation

@Delta456
Copy link
Copy Markdown
Member

@Delta456 Delta456 commented Jun 18, 2025 •
edited by qodo-code-review bot
Loading

User description

🔗 Related Issues

Fixes #15905 for Java binding

💥 What does this PR do?

Deprecates FTP Proxy as it is no longer supported by browsers

🔧 Implementation Notes

Uses @Deprecated attribute to mark symbols deprecated

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)

PR Type

Other

Description

• Deprecate FTP proxy support in Java binding
• Mark FTP proxy constants and methods with @deprecated annotation
• Add deprecation warnings to getFtpProxy and setFtpProxy methods

Changes walkthrough 📝

Relevant files
Enhancement
Proxy.java
Deprecate FTP proxy constants and methods                               

java/src/org/openqa/selenium/Proxy.java

• Added @deprecated annotation to FTP_PROXY constant
• Added
@deprecated annotation to ftpProxy field
• Added @deprecated
annotation and deprecation warnings to getFtpProxy() method
• Added
@deprecated annotation and deprecation warnings to setFtpProxy()
method

 +6/-2     
Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @selenium-ci selenium-ci added the C-java Java Bindings label Jun 18, 2025
    @qodo-code-review
    Copy link
    Copy Markdown
    Contributor

    qodo-code-review bot commented Jun 18, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ✅

    15905 - PR Code Verified

    Compliant requirements:

    • Deprecate FTP Proxy support from Java binding
    • Address the fact that FTP Proxy is no longer supported by browsers

    Requires further human verification:

    • Verification that deprecation is applied to all other bindings (C-py, C-rb, C-dotnet, C-nodejs)
    • Confirmation that future removal timeline is established

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Missing Documentation

    The deprecation messages should include information about why FTP proxy is being deprecated (browser support removal) and potentially suggest alternatives or migration path for users.

     
     * @deprecated getFtpProxy is deprecated and will be removed in a future release.
 */
@Deprecated
public @Nullable String getFtpProxy() {
  return ftpProxy;
}

/**
 * Specify which proxy to use for FTP connections.
 *
 * @param ftpProxy the proxy host, expected format is <code>hostname.com:1234</code>
 * @return reference to self
 * @deprecated setFtpProxy is deprecated and will be removed in a future release.
 */

    @qodo-code-review
    Copy link
    Copy Markdown
    Contributor

    qodo-code-review bot commented Jun 18, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @Delta456 Delta456 mentioned this pull request Jun 18, 2025
    Closed
    @Delta456 Delta456 merged commit e943cc1 into SeleniumHQ:trunk Jun 18, 2025
    35 of 37 checks passed
    @Delta456 Delta456 deleted the java_ftp_proxy_deprecate branch June 18, 2025 09:36
    @Delta456
    Copy link
    Copy Markdown
    Member Author

    Delta456 commented Jun 18, 2025

    CI failure is not related to my PR

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @diemol diemol diemol approved these changes

    Assignees

    No one assigned

    Labels

    C-java Java Bindings Review effort 2/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    [🚀 Feature]: Deprecate/Remove FTP Proxy support from all bindings

    3 participants

    @Delta456 @diemol @selenium-ci