[py] Deprecate support for FTP proxies#15906
Merged
cgoldberg merged 4 commits intoSeleniumHQ:trunkfrom Jun 19, 2025
Merged
Conversation
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
AutomatedTester
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
#15905
💥 What does this PR do?
This PR adds a deprecation warning when trying to set an
ftpProxy.💡 Additional Considerations
Newer browsers already don't support FTP proxies, but we will deprecate it in case users are pinned to older browsers that still support it.
🔄 Types of changes
PR Type
Other
Description
• Deprecate FTP proxy support with warning message
• Add TODO comments for future removal
• Update tests with deprecation comments
• Minor formatting improvements to docstrings
Changes walkthrough 📝
proxy.py
Add FTP proxy deprecation warningpy/selenium/webdriver/common/proxy.py
• Add deprecation warning when setting
ftpProxy• Import warnings
module for deprecation handling
• Add TODO comments for future removal
• Minor docstring formatting improvements
proxy_tests.py
Update tests with deprecation commentspy/test/selenium/webdriver/common/proxy_tests.py
• Add TODO comments referencing FTP proxy deprecation
• Update test
comments to indicate deprecated status
• Reference GitHub issue for
future removal